Replace listener::onFailure with handleError after GENERATING status is written

Signed-off-by: shuangli-z <[email protected]>

Author: shuangli-z

common/src/main/java/org/opensearch/ml/common/indexInsight/AbstractIndexInsightTask.java

@@ -105,7 +105,7 @@ public void execute(String tenantId, ActionListener<IndexInsight> listener) {
                     .whenComplete((r, throwable) -> {
                         if (throwable != null) {
                             Exception cause = SdkClientUtils.unwrapAndConvertToException(throwable);
-                            listener.onFailure(cause);
+                            handleError("Failed to search pattern matched documents for index: {}", cause, tenantId, listener, false);
                         } else {
                             SearchResponse searchResponse = r.searchResponse();
                             SearchHit[] hits = searchResponse.getHits().getHits();
@@ -203,9 +203,11 @@ protected void beginGeneration(String tenantId, ActionListener<IndexInsight> lis
             .lastUpdatedTime(Instant.now())
             .build();
 
-        writeIndexInsight(indexInsight, tenantId, ActionListener.wrap(r -> { runWithPrerequisites(tenantId, listener); }, e -> {
-            saveFailedStatus(tenantId, e, listener);
-        }));
+        writeIndexInsight(
+            indexInsight,
+            tenantId,
+            ActionListener.wrap(r -> { runWithPrerequisites(tenantId, listener); }, listener::onFailure)
+        );
     }
 
     protected void runWithPrerequisites(String tenantId, ActionListener<IndexInsight> listener) {
@@ -239,7 +241,7 @@ protected void saveResult(String content, String tenantId, ActionListener<IndexI
             .build();
 
         writeIndexInsight(insight, tenantId, ActionListener.wrap(r -> { listener.onResponse(insight); }, e -> {
-            saveFailedStatus(tenantId, e, listener);
+            handleError("Failed to save completed result for index: {}", e, tenantId, listener);
         }));
     }
 

common/src/main/java/org/opensearch/ml/common/indexInsight/FieldDescriptionTask.java

@@ -128,17 +128,12 @@ protected void handlePatternResult(Map<String, Object> patternSource, String ten
                     listener.onResponse(insight);
 
                 } catch (Exception e) {
-                    log.error("Failed to process current index mapping for index {}", sourceIndex, e);
-                    listener.onFailure(e);
+                    handleError("Failed to process current index mapping for index: {}", e, tenantId, listener, false);
                 }
-            }, e -> {
-                log.error("Failed to get current index mapping for index {}", sourceIndex, e);
-                listener.onFailure(e);
-            }));
+            }, e -> { handleError("Failed to get current index mapping for index: {}", e, tenantId, listener, false); }));
 
         } catch (Exception e) {
-            log.error("Failed to filter field descriptions for index {}", sourceIndex, e);
-            listener.onFailure(e);
+            handleError("Failed to filter field descriptions for index: {}", e, tenantId, listener, false);
         }
     }
 
@@ -233,7 +228,10 @@ private void processBatch(
                 log.error("Error parsing response for batch in index {}: {}", sourceIndex, e.getMessage());
                 listener.onFailure(e);
             }
-        }, e -> { listener.onFailure(e); }));
+        }, e -> {
+            log.error("Failed to call LLM for batch processing in index {}: {}", sourceIndex, e.getMessage());
+            listener.onFailure(e);
+        }));
     }
 
     private String generateBatchPrompt(List<String> batchFields, Map<String, Object> statisticalContentMap) {

common/src/main/java/org/opensearch/ml/common/indexInsight/LogRelatedIndexCheckTask.java

@@ -98,7 +98,7 @@ public void runTask(String tenantId, ActionListener<IndexInsight> listener) {
                             e -> handleError("Failed to get agent ID from ML config", e, tenantId, listener)
                         )
                 );
-            }, listener::onFailure));
+            }, e -> handleError("Failed to collect sample documents for index: {}", e, tenantId, listener)));
         } catch (Exception e) {
             handleError("Failed log related check for index: {}", e, tenantId, listener);
         }

common/src/main/java/org/opensearch/ml/common/indexInsight/StatisticalDataTask.java

@@ -122,7 +122,13 @@ private void collectStatisticalData(String tenantId, boolean shouldStore, Action
         client.admin().indices().getMappings(getMappingsRequest, ActionListener.wrap(getMappingsResponse -> {
             Map<String, MappingMetadata> mappings = getMappingsResponse.getMappings();
             if (mappings.isEmpty()) {
-                listener.onFailure(new IllegalArgumentException("No matching mapping with index name: " + sourceIndex));
+                handleError(
+                    "No matching mapping with index name: {}",
+                    new IllegalArgumentException("No matching mapping with index name: " + sourceIndex),
+                    tenantId,
+                    listener,
+                    shouldStore
+                );
                 return;
             }
 
@@ -169,9 +175,9 @@ private void collectStatisticalData(String tenantId, boolean shouldStore, Action
                             .build();
                         listener.onResponse(insight);
                     }
-                }, listener::onFailure));
+                }, e -> handleError("Failed to filter important columns by LLM for index: {}", e, tenantId, listener, shouldStore)));
             }, e -> handleError("Failed to collect statistical data for index: {}", e, tenantId, listener, shouldStore)));
-        }, listener::onFailure));
+        }, e -> handleError("Failed to get mappings for index: {}", e, tenantId, listener, shouldStore)));
     }
 
     @Override