Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDK-23 to the build matrix #977

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/notifications-test-and-build-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# This setting says that all jobs should finish, even if one fails
fail-fast: false
matrix:
java: [21]
java: [21, 23]

# Job name
name: Build Notifications with JDK ${{ matrix.java }} on linux
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
# This setting says that all jobs should finish, even if one fails
fail-fast: false
matrix:
java: [21]
java: [21, 23]
os: [ windows-latest, macos-latest ]
include:
- os: windows-latest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
# This setting says that all jobs should finish, even if one fails
fail-fast: false
matrix:
java: [21]
java: [21, 23]

runs-on: ubuntu-latest

Expand Down
2 changes: 1 addition & 1 deletion notifications/build-tools/merged-coverage.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

allprojects {
plugins.withId('jacoco') {
jacoco.toolVersion = '0.8.11'
jacoco.toolVersion = '0.8.12'
// For some reason this dependency isn't getting setup automatically by the jacoco plugin
tasks.withType(JacocoReport) {
dependsOn tasks.withType(Test)
Expand Down
2 changes: 1 addition & 1 deletion notifications/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ buildscript {
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${kotlin_version}"
classpath "org.jetbrains.kotlin:kotlin-allopen:${kotlin_version}"
classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.23.0"
classpath "org.jacoco:org.jacoco.agent:0.8.11"
classpath "org.jacoco:org.jacoco.agent:0.8.12"
}

configurations {
Expand Down
2 changes: 1 addition & 1 deletion notifications/core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ dependencies {
'org.assertj:assertj-core:3.16.1',
'org.junit.jupiter:junit-jupiter-api:5.6.2',
"org.junit.jupiter:junit-jupiter-params:5.6.2",
"org.easymock:easymock:5.2.0",
"org.easymock:easymock:5.4.0",
"org.apache.logging.log4j:log4j-core:${versions.log4j}",
'org.mockito:mockito-junit-jupiter:3.10.0',
'com.nhaarman.mockitokotlin2:mockito-kotlin:2.2.0',
Expand Down
Loading