Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Remove properties with x-version-added/removed when checking schema #425

Closed
dblock opened this issue Jul 16, 2024 · 0 comments · Fixed by #428
Closed

[FEATURE] Remove properties with x-version-added/removed when checking schema #425

dblock opened this issue Jul 16, 2024 · 0 comments · Fixed by #428
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Jul 16, 2024

Is your feature request related to a problem?

Coming from #424 we are adding x-version-removed in various fields. However, these fields are still included when checking schema against a server version >= version removed.

What solution would you like?

When running tests against OpenSearch X, schema verification should delete fields that are x-version-removed <= X, and fields that are x-version-added > X.
@dblock dblock added enhancement New feature or request untriaged and removed untriaged labels Jul 16, 2024
@dblock dblock changed the title [FEATURE] Remove properties with x-version-removed when checking schema [FEATURE] Remove properties with x-version-added/removed when checking schema Jul 16, 2024
@dblock dblock removed the untriaged label Jul 16, 2024
@dblock dblock mentioned this issue Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@dblock