Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure log to autocut build failures per plugin #4607

Open
2 tasks
jmazanec15 opened this issue Apr 4, 2024 · 6 comments
Open
2 tasks

Add failure log to autocut build failures per plugin #4607

jmazanec15 opened this issue Apr 4, 2024 · 6 comments
Assignees
Labels
enhancement New Enhancement

Comments

@jmazanec15
Copy link
Member

jmazanec15 commented Apr 4, 2024

Is your feature request related to a problem? Please describe

Auto-cut failures plugins get do not contain information about the failure. Plugin devs have to parse logs with other component builds to see what caused failure. This increases time to rootcause and fix.

ref: opensearch-project/k-NN#1591

image

Describe the solution you'd like

Would like to see failure for build posted as part of the issue so that root cause could be determined quicker.

Describe alternatives you've considered

Parsing the logs

Acceptance Criteria

  • Give the exact build failure of each plugin.
  • Show the outputs of build of all components for all architectures and platforms.
@jmazanec15 jmazanec15 added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Apr 4, 2024
@gaiksaya
Copy link
Member

gaiksaya commented Apr 8, 2024

Hi @jmazanec15 ,

We are creating a generic autocut failure issues for all platforms/architectures combinations. It would be difficult to parse the all stages and get specific failure. Currently, the logic is even if we find one Error building string, it would create an issue for that component.

I believe, along with the workflow run, it would be helpful to provide specific node raw logs. Example: https://build.ci.opensearch.org/blue/rest/organizations/jenkins/pipelines/distribution-build-opensearch/runs/9674/nodes/72/steps/491/log/?start=0

What do you think?

P.S: I am not sure if it possible to get this URL dynamically.

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Apr 8, 2024
@jmazanec15
Copy link
Member Author

But if we can find the "Error building" string, couldnt we get the logs? For instance, dont we run ./gradlew integTest? Can we capture the exit code and check and cut issue based on that?

Raw node logs would also be helpful

@zelinh
Copy link
Member

zelinh commented Apr 15, 2024

Right now for test workflow, we are using report workflow to generate a test-report including all the logs from the testing. We can have a build_recorder similar to the test_recorder (https://github.com/opensearch-project/opensearch-build/tree/main/src/test_workflow/test_recorder) so that we could enhance current report workflow to create reports for building workflow as well.

@peterzhuamazon
Copy link
Member

[Triage] We can think of other ways to solve this such as:

  • Adding a tee to each gradle/yarn build command in build.sh > into a specific plugin named log file
  • Attach the log as part of the jenkins run
  • Add the log url as part of the description/comment of the github issue.

Thanks.

@Swiddis
Copy link
Contributor

Swiddis commented Jun 14, 2024

Can I get this assigned to me?

@peterzhuamazon
Copy link
Member

Thanks @Swiddis contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
Status: Backlog
Development

No branches or pull requests

5 participants