Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest url update toggle on distribution workflows #2881

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Nov 10, 2022

Signed-off-by: Peter Zhu [email protected]

Description

Add latest url update toggle on distribution workflows

Issues Resolved

#2649
Partially on #2749.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added the enhancement New Enhancement label Nov 10, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner November 10, 2022 19:28
@peterzhuamazon peterzhuamazon self-assigned this Nov 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #2881 (6b702f5) into main (449cee4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2881   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         158      158           
  Lines        4401     4401           
=======================================
  Hits         4125     4125           
  Misses        276      276           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As offline discussion with @peterzhuamazon, the use case for this param will be when we want to pushing only OpenSearch min to maven but we want the latest index still pointing to the last bundle including all plugins.

Signed-off-by: Peter Zhu <[email protected]>
@gaiksaya
Copy link
Member

@peterzhuamazon Does this solve #2749 ? Would take input from there before proceeding

@peterzhuamazon
Copy link
Member Author

@peterzhuamazon Does this solve #2749 ? Would take input from there before proceeding

Thanks @gaiksaya I replied to that issue and will merge this for now.
We can always revert this as it is a very simple change.
The default option runs exactly like before.

@peterzhuamazon peterzhuamazon merged commit ed8f598 into opensearch-project:main Nov 10, 2022
@peterzhuamazon peterzhuamazon deleted the adding_skip_latest branch November 10, 2022 20:24
mnin added a commit to graylog-labs/opensearch-build that referenced this pull request Nov 16, 2022
# By Peter Zhu (8) and others
# Via GitHub
* upstream/main: (24 commits)
  Updated manifests. (opensearch-project#2894)
  Update ref for 2.4.0 with tags (opensearch-project#2906)
  Fix status syntax for gradle check (opensearch-project#2907)
  Add the consolidated release notes for 2.4.0 release (opensearch-project#2887)
  Revert set output command (opensearch-project#2903)
  Fix status code for gradle check with retry (opensearch-project#2902)
  Upgrade actions and remove deprecated set ouput commands (opensearch-project#2901)
  Update opensearch-2.4.0.yml (opensearch-project#2896)
  Resolve Window IntegTest copy and startup issues (opensearch-project#2892)
  Update IM ref to include fix (opensearch-project#2890)
  Fix manifest workflow failure (opensearch-project#2889)
  Install twine on clients image (opensearch-project#2884)
  Freeze the ref with commit ID (opensearch-project#2882)
  Add latest url update toggle on distribution workflows (opensearch-project#2881)
  Update promoteArtifacts to support win/zip and add timer for gradle check windows (opensearch-project#2869)
  Fix signing the artifacts for .asc signatures (opensearch-project#2850)
  Update the ref with 2.4 branch for OSD. (opensearch-project#2855)
  Update the OSD manifest with commit ID (opensearch-project#2862)
  Add gradle check support for windows agent (opensearch-project#2860)
  Add default copy for opensearch-dashboards yml and docker entrypoint (opensearch-project#2861)
  ...

# Conflicts:
#	scripts/components/OpenSearch-Dashboards/install.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants