Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Code snippets in Guides #664

Open
nhtruong opened this issue Dec 7, 2023 · 1 comment
Open

Correct Code snippets in Guides #664

nhtruong opened this issue Dec 7, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@nhtruong
Copy link
Collaborator

nhtruong commented Dec 7, 2023

Many of our guides were almost copied and pasted from the Ruby guides without adapting to the JS client. We need to go through all of them and make sure that the snippets can run AND the features mentioned in the guides are supported by the JS client.
@nhtruong nhtruong added good first issue Good for newcomers and removed untriaged labels Dec 7, 2023
@dblock
Copy link
Member

dblock commented Dec 8, 2023

Ouch. I propose we require a working sample along with each guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @nhtruong