Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implementing Abstract Base Class for future model additions in ml_models #362

Open
rawwar opened this issue Dec 19, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@rawwar
Copy link
Contributor

rawwar commented Dec 19, 2023

Is your feature request related to a problem?
Since, we want to support multiple types of models, we can standardize this by having a abstract base class.

What solution would you like?
I would like to introduce an abstract base class that encapsulates the common functionality shared by different model classes. This would promote code reusability and provide a consistent interface for all derived classes.

Do you have any additional context?
This change would affect the SentenceTransformerModel class and Q&A model that's work in progress. We would need to refactor these classes to inherit from the new abstract base class.

@rawwar rawwar added enhancement New feature or request untriaged labels Dec 19, 2023
@dhrubo-os
Copy link
Collaborator

that's good idea!

@dblock
Copy link
Member

dblock commented Jun 17, 2024

Catch All Triage - 1 2 3 4 5

@rawwar any interest in picking this up?

@dblock dblock removed the untriaged label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants