Add Windows Support #191

dblock · 2021-10-27T13:40:54Z

Coming from opensearch-project/opensearch-plugins#95, add Windows support.

Passing CI on Windows
Documentation

peterzhuamazon · 2022-07-08T17:57:58Z

Hi Team.

Please look into adding Windows x64/arm64 Chromium Binary for this reports plugin.

As we are starting the process of Windows support.

Thanks.

anirudha · 2022-07-08T18:10:20Z

In the queue... We need to research windows arm.

joshuali925 · 2022-07-08T18:23:57Z

@setiah or @peterzhuamazon is it confirmed that we will be supporting windows arm64? if so, windows server never released arm64 version (ref), will this be targeting windows 10/11 arm64?

additionally we might be able to run the full chromium in headless mode, but it increases reporting artifact size about 200mb, would it be acceptable or is there a hard limit on artifact size?

peterzhuamazon · 2022-07-08T22:58:41Z

Adding @bbarani in the conversation of this.

setiah · 2022-07-13T04:56:17Z

@setiah or @peterzhuamazon is it confirmed that we will be supporting windows arm64? if so, windows server never released arm64 version (ref), will this be targeting windows 10/11 arm64?

This is relatively new https://www.zdnet.com/article/microsoft-brings-arm-support-to-azure-virtual-machines/
and I think it should be okay to skip. Elasticsearch doesn't support it and I doubt if it was ever supported for ODFE. The FAQs on opensearch-project/opensearch-build#2312 mention arm64 still in research -

Q4: What CPU architecture do you support in the Windows distribution?
A4: We are aiming to release x64 architecture support 1st, arm64 architecture for Windows is still in research.

peterzhuamazon · 2022-09-30T17:51:35Z

Hi @anirudha @joshuali925 what is the progress on chromium support on this?
Would love to see some updates! Thanks. 😄

cc: @setiah

anirudha · 2022-10-13T16:25:46Z

researching this further, we will post an update soon on this

derek-ho · 2022-10-17T17:41:46Z

Blocked on windows chromium binary incompatibility with pupeteer. Doing some investigation to see whether newer version of chromium will fix this issue. If so then we may need to create a new windows headless chromium binary CC @rupal-bq @joshuali925

rupal-bq · 2022-10-17T18:01:58Z

Tried building locally on windows but build failed with following error.

ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: C:\Users\Administrator\AppData\Roaming\nvm\v14.20.0\node_modules\yarn\bin\yarn.js run osd:bootstrap
      'rm' is not recognized as an internal or external command,
      operable program or batch file.
      error Command failed with exit code 1.
      $ rm -rf target && tsc
      info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
          at makeError (C:\Users\Administrator\Opensearch-Dashboards\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:25150:11)
          at handlePromise (C:\Users\Administrator\Opensearch-Dashboards\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:24085:26)
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async C:\Users\Administrator\Opensearch-Dashboards\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:9051:9
          at async scheduleItem (C:\Users\Administrator\Opensearch-Dashboards\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:10938:9)
error Command failed with exit code 1.

Blocked on dashboards support

rupal-bq · 2022-10-17T19:35:45Z

Tried building locally on windows but build failed with following error.

ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: C:\Users\Administrator\AppData\Roaming\nvm\v14.20.0\node_modules\yarn\bin\yarn.js run osd:bootstrap
      'rm' is not recognized as an internal or external command,
      operable program or batch file.
      error Command failed with exit code 1.
      $ rm -rf target && tsc
      info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
          at makeError (C:\Users\Administrator\Opensearch-Dashboards\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:25150:11)
          at handlePromise (C:\Users\Administrator\Opensearch-Dashboards\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:24085:26)
          at processTicksAndRejections (internal/process/task_queues.js:95:5)
          at async C:\Users\Administrator\Opensearch-Dashboards\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:9051:9
          at async scheduleItem (C:\Users\Administrator\Opensearch-Dashboards\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:10938:9)
error Command failed with exit code 1.

Blocked on dashboards support

Switching to git bash fixed this error

rupal-bq · 2022-10-18T18:08:47Z

Was able to download report on windows with dev server

download_dashboards_report_windows.mov

derek-ho · 2022-10-18T23:09:31Z

@rupal-bq and I were able to get this to work with a newer version of chromium. CI is also passing on PR. Will connect with @joshuali925 about generating a newer version of headless chromium binary for windows.

derek-ho · 2022-10-20T16:26:22Z

Merged the PR

derek-ho · 2022-10-20T16:26:26Z

@joshuali925 @rupal-bq can one of you folks close this issue? I don't have access....

joshuali925 · 2022-10-20T16:28:30Z

closed by #504

peterzhuamazon · 2022-10-20T17:59:00Z

Reopen as the code is only in main.
@derek-ho @joshuali925 could you please add it to 2.x branch backport?

Thanks.

joshuali925 · 2022-10-20T20:54:52Z

backported

peterzhuamazon · 2022-10-25T00:23:02Z

Not able to build on windows:

+ yarn plugin_helpers build --opensearch-dashboards-version=2.4.0
yarn run v1.22.19
$ node ../../scripts/plugin_helpers build --opensearch-dashboards-version=2.4.0
ERROR Plugin located at [C:\Users\Administrator\AppData\Local\Temp\2\tmp8knjp6j1\OpenSearch-Dashboards\plugins\dashboards-reports] must be moved to the plugins directory at the root of the OpenSearch Dashboards
error Command failed with exit code 1.

Despite the dir is in the plugins folder the build still not start.

joshuali925 · 2022-10-25T16:52:18Z

@peterzhuamazon not able to reproduce, need more information

here is a successful build: https://github.com/opensearch-project/dashboards-reports/actions/runs/3292567970/jobs/5428079881

anirudha · 2022-10-25T16:58:14Z

closing this as per the comment

bbarani · 2022-10-25T17:51:06Z

@anirudha Can we please keep this issue open until you hear back from @peterzhuamazon

peterzhuamazon · 2022-10-25T17:57:25Z

Verifying the issue right now will post my findings soon.

Thanks.

peterzhuamazon · 2022-10-25T20:16:20Z

I have confirmed that the folder is the correct folder in the correct location, yet it is still not able to build reports dash.

+ pwd
/tmp/tmpzgwnkv7a/OpenSearch-Dashboards/plugins/dashboards-reports
+ ls -l
total 611
-rw-r--r-- 1 Administrator 197121   2791 Oct 25 20:12 DEVELOPER_GUIDE.md
-rw-r--r-- 1 Administrator 197121   2171 Oct 25 20:12 README.md
-rw-r--r-- 1 Administrator 197121  11323 Oct 25 20:12 THIRD-PARTY
-rw-r--r-- 1 Administrator 197121    579 Oct 25 20:12 babel.config.js
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:12 builds
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:12 common
-rw-r--r-- 1 Administrator 197121    517 Oct 25 20:12 cypress.json
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:13 node_modules
-rw-r--r-- 1 Administrator 197121    288 Oct 25 20:12 opensearch_dashboards.json
-rw-r--r-- 1 Administrator 197121   2567 Oct 25 20:12 package.json
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:12 public
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:12 rendering-engine
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:12 server
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:12 test
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:12 translations
-rw-r--r-- 1 Administrator 197121    829 Oct 25 20:12 tsconfig.json
-rw-r--r-- 1 Administrator 197121 317485 Oct 25 20:12 yarn.lock
+ yarn plugin_helpers build --opensearch-dashboards-version=2.4.0
yarn run v1.22.19
$ node ../../scripts/plugin_helpers build --opensearch-dashboards-version=2.4.0
ERROR Plugin located at [C:\Users\Administrator\AppData\Local\Temp\2\tmpzgwnkv7a\OpenSearch-Dashboards\plugins\dashboards-reports] must be moved to the plugins directory at the root of the OpenSearch Dashboards repo
error Command failed with exit code 1.

peterzhuamazon · 2022-10-25T20:20:03Z

Seems like it is caused by this exception in core dashboards:
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/d7004dc5b0392477fdd54ac66b29d231975a173b/packages/osd-plugin-helpers/src/load_opensearch_dashboards_platform_plugin.ts#L47

joshuali925 · 2022-10-25T20:32:54Z

could you give steps to reproduce?

Administrator@ MINGW64 ~/Downloads/opensearch-dashboards/plugins/dashboards-reports (2.x)
$ ls -l
total 611
-rw-r--r-- 1 Administrator 197121   2791 Oct 13 17:13 DEVELOPER_GUIDE.md
-rw-r--r-- 1 Administrator 197121   2171 Oct 13 17:13 README.md
-rw-r--r-- 1 Administrator 197121  11323 Oct 13 17:13 THIRD-PARTY
-rw-r--r-- 1 Administrator 197121    579 Oct 13 17:13 babel.config.js
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:28 build
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:24 common
-rw-r--r-- 1 Administrator 197121    517 Oct 13 17:13 cypress.json
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:26 node_modules
-rw-r--r-- 1 Administrator 197121    288 Oct 25 20:23 opensearch_dashboards.json
-rw-r--r-- 1 Administrator 197121   2567 Oct 25 20:23 package.json
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:24 public
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:24 rendering-engine
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:24 server
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:24 test
drwxr-xr-x 1 Administrator 197121      0 Oct 25 20:24 translations
-rw-r--r-- 1 Administrator 197121    829 Oct 13 17:13 tsconfig.json
-rw-r--r-- 1 Administrator 197121 317485 Oct 25 20:23 yarn.lock

Administrator@ MINGW64 ~/Downloads/opensearch-dashboards/plugins/dashboards-reports (2.x)
$ yarn plugin_helpers build --opensearch-dashboards-version=2.4.0
yarn run v1.22.19
$ node ../../scripts/plugin_helpers build --opensearch-dashboards-version=2.4.0
 info Loaded config file from [C:\Users\Administrator\Downloads\opensearch-dashboards\plugins\dashboards-reports\.opensearch_dashboards-plugin-helpers.json]
 info deleting the build and target directories
 info running @osd/optimizer
 │ info initialized, 0 bundles cached
 │ info starting worker [1 bundle]
 │ succ 1 bundles compiled successfully after 13.7 sec
 info copying assets from `public/assets` to build
 info copying server source into the build and converting with babel
 info running yarn to install dependencies
 info compressing plugin into [reportsDashboards-2.4.0.zip]
Done in 40.88s.

anirudha · 2022-10-25T21:16:30Z

I am going to close this issue, unless we need to do more work in reporting plugin

peterzhuamazon · 2022-10-25T21:18:45Z

Re-open the issue as we are able to reproduce this specifically on jenkins windows agent.
Debugging with @joshuali925.

Thanks.

peterzhuamazon · 2022-10-25T21:32:01Z

The issue seems related to dashboards core code returning two different paths literally, but for windows they are the same path:

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/d7004dc5b0392477fdd54ac66b29d231975a173b/packages/osd-plugin-helpers/src/load_opensearch_dashboards_platform_plugin.ts#L47

  const isRootPlugin = parentDir === Path.resolve(REPO_ROOT, 'plugins');

C:\Users\Administrator\AppData\Local\Temp\2\tmpndbrtuhg\OpenSearch-Dashboards\plugins
C:\Users\ADMINI~1\AppData\Local\Temp\2\tmpndbrtuhg\OpenSearch-Dashboards\plugins

In Windows Administrator dir and ADMINI~1 dir is being treated as the same but in typescript === comparison they are not the same, thus fail build.

peterzhuamazon · 2022-10-25T21:35:51Z

Add a new issue in core about this.

[Bug] Path comparison issues causing plugin not able to build on Windows OpenSearch-Dashboards#2669
Thanks @anirudha @derek-ho @rupal-bq @joshuali925 for the help.

dblock · 2022-11-03T21:07:29Z

I don't believe integration tests are running, and integration tests are very much part of CI. Reopening. Please close when this and any other gaps between Linux/Windows CI/CD are covered.

peterzhuamazon · 2022-11-21T18:53:06Z

Hi, just want to make sure this issue is closed, if all the tasks are completed.

Thanks.

rupal-bq · 2023-01-10T00:49:33Z

Added integration tests in CI #624. Closing this issue.

dblock added the windows label Oct 27, 2021

dblock mentioned this issue Oct 27, 2021

[META] Add Windows Support opensearch-project/opensearch-plugins#95

Open

28 tasks

derek-ho mentioned this issue Oct 11, 2022

feat: enable windows and macos build #504

Merged

6 tasks

joshuali925 closed this as completed Oct 20, 2022

peterzhuamazon reopened this Oct 20, 2022

joshuali925 mentioned this issue Oct 20, 2022

[BACKPORT 2.x] feat: enable windows and macos build (#504) #511

Merged

6 tasks

joshuali925 closed this as completed Oct 20, 2022

peterzhuamazon reopened this Oct 25, 2022

peterzhuamazon mentioned this issue Oct 25, 2022

[WIN M1] WIN (ZIP/MSI) Build/Assemble Process opensearch-project/opensearch-build#2306

Closed

1 task

anirudha closed this as completed Oct 25, 2022

bbarani reopened this Oct 25, 2022

anirudha closed this as completed Oct 25, 2022

peterzhuamazon reopened this Oct 25, 2022

peterzhuamazon mentioned this issue Oct 25, 2022

[Bug] Path comparison issues causing plugin not able to build on Windows opensearch-project/OpenSearch-Dashboards#2669

Closed

peterzhuamazon closed this as completed Oct 25, 2022

dblock reopened this Nov 3, 2022

rupal-bq mentioned this issue Jan 9, 2023

Include integration tests in windows and macOS workflow #624

Merged

6 tasks

rupal-bq closed this as completed Jan 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Windows Support #191

Add Windows Support #191

dblock commented Oct 27, 2021 •

edited by anirudha

Loading

peterzhuamazon commented Jul 8, 2022

anirudha commented Jul 8, 2022

joshuali925 commented Jul 8, 2022

peterzhuamazon commented Jul 8, 2022

setiah commented Jul 13, 2022 •

edited

Loading

peterzhuamazon commented Sep 30, 2022

anirudha commented Oct 13, 2022

derek-ho commented Oct 17, 2022

rupal-bq commented Oct 17, 2022

rupal-bq commented Oct 17, 2022

rupal-bq commented Oct 18, 2022

derek-ho commented Oct 18, 2022

derek-ho commented Oct 20, 2022

derek-ho commented Oct 20, 2022

joshuali925 commented Oct 20, 2022

peterzhuamazon commented Oct 20, 2022

joshuali925 commented Oct 20, 2022

peterzhuamazon commented Oct 25, 2022

joshuali925 commented Oct 25, 2022

anirudha commented Oct 25, 2022

bbarani commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022 •

edited

Loading

peterzhuamazon commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022 •

edited

Loading

joshuali925 commented Oct 25, 2022

anirudha commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022 •

edited

Loading

dblock commented Nov 3, 2022

peterzhuamazon commented Nov 21, 2022

rupal-bq commented Jan 10, 2023

Add Windows Support #191

Add Windows Support #191

Comments

dblock commented Oct 27, 2021 • edited by anirudha Loading

peterzhuamazon commented Jul 8, 2022

anirudha commented Jul 8, 2022

joshuali925 commented Jul 8, 2022

peterzhuamazon commented Jul 8, 2022

setiah commented Jul 13, 2022 • edited Loading

peterzhuamazon commented Sep 30, 2022

anirudha commented Oct 13, 2022

derek-ho commented Oct 17, 2022

rupal-bq commented Oct 17, 2022

rupal-bq commented Oct 17, 2022

rupal-bq commented Oct 18, 2022

derek-ho commented Oct 18, 2022

derek-ho commented Oct 20, 2022

derek-ho commented Oct 20, 2022

joshuali925 commented Oct 20, 2022

peterzhuamazon commented Oct 20, 2022

joshuali925 commented Oct 20, 2022

peterzhuamazon commented Oct 25, 2022

joshuali925 commented Oct 25, 2022

anirudha commented Oct 25, 2022

bbarani commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022 • edited Loading

peterzhuamazon commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022 • edited Loading

joshuali925 commented Oct 25, 2022

anirudha commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022

peterzhuamazon commented Oct 25, 2022 • edited Loading

dblock commented Nov 3, 2022

peterzhuamazon commented Nov 21, 2022

rupal-bq commented Jan 10, 2023

dblock commented Oct 27, 2021 •

edited by anirudha

Loading

setiah commented Jul 13, 2022 •

edited

Loading

peterzhuamazon commented Oct 25, 2022 •

edited

Loading

peterzhuamazon commented Oct 25, 2022 •

edited

Loading

peterzhuamazon commented Oct 25, 2022 •

edited

Loading