Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Support #845

Closed
3 tasks done
Tracked by #95
dblock opened this issue Oct 27, 2021 · 12 comments
Closed
3 tasks done
Tracked by #95

Add Windows Support #845

dblock opened this issue Oct 27, 2021 · 12 comments
Assignees

Comments

@dblock
Copy link
Member

dblock commented Oct 27, 2021

Coming from opensearch-project/opensearch-plugins#95, add Windows support.

@dblock dblock added the windows label Oct 27, 2021
@davidlago davidlago added the v2.4.0 'Issues and PRs related to version v2.4.0' label Oct 24, 2022
@peternied peternied self-assigned this Oct 24, 2022
@cwperks cwperks self-assigned this Oct 24, 2022
@bbarani
Copy link
Member

bbarani commented Oct 26, 2022

@cwperks Can you please update the current status?

@cwperks
Copy link
Member

cwperks commented Oct 26, 2022

@peternied Please provide on update on running CI on windows

For the issue of not having a batch equivalent of the install_demo_configuration.sh (opensearch-project/security#2148) there is a PR, but we are facing an issue with the automated validation of the change against main.

The plugin_install workflow has been extended to verify the installation on both linux and windows, but the issue being faced now is that an opensearch node cannot be started on the windows-latest runner because windows-latest runs as admin and the node will not start if its run as root. This is actively being worked on and we hope to find a solution shortly.

The build-time validation does work on 2.x, but only because the automatic backport of this change failed: opensearch-project/OpenSearch#4656

@peternied
Copy link
Member

This is queued up to be worked on next, as soon as I get the backend plugin ready for review for CI on Windows opensearch-project/security#2190

@peternied
Copy link
Member

Note, I'm moving the integration test work out into its own task. It was not a core requirement for the windows platform release and we can fast follow to get it included.

@dblock
Copy link
Member Author

dblock commented Nov 3, 2022

I am not sure why we say integration tests weren't part of this work. Reopening. Let's close when there's no gap between testing on Linux and Windows.

@dblock dblock reopened this Nov 3, 2022
@peterzhuamazon
Copy link
Member

Hi, just want to make sure this issue is closed, if all the tasks are completed.

Thanks.

@peternied peternied removed the v2.4.0 'Issues and PRs related to version v2.4.0' label Nov 29, 2022
@peternied
Copy link
Member

This is not complete, it is still a work in progress, I've removed the 2.4.0 label

@peternied peternied assigned RyanL1997 and unassigned peternied Nov 29, 2022
@CEHENKLE
Copy link
Member

@peternied What release are you targeting?

@peternied
Copy link
Member

@CEHENKLE Missed the 2.5.0 release, targeting 2.6.0 @RyanL1997 is actively working this, see the follow PR for status:

@cwperks
Copy link
Member

cwperks commented Feb 3, 2023

#1275 has been merged. @peternied is there anything remaining for this ticket or can it be closed?

@peternied
Copy link
Member

@RyanL1997 as the one who took this on, would you do the honors and close this issue?

@RyanL1997
Copy link
Collaborator

Closing this one since the #1275 has been merged. Thank you all for the support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants