Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] nested/object query with raw or csv format inserts unexpected newlines #1572

Closed
acarbonetto opened this issue Apr 21, 2023 · 3 comments · Fixed by #1779
Closed

[BUG] nested/object query with raw or csv format inserts unexpected newlines #1572

acarbonetto opened this issue Apr 21, 2023 · 3 comments · Fixed by #1779
Labels
bug Something isn't working v2.9.0 v2.9.0

Comments

@acarbonetto
Copy link
Collaborator

What is the bug?
When using the raw or csv format output in SQL plugin, we expect each row of output to correspond with a row from the response.

for example, from SELECT nested(message.info), nested(comment.data) FROM nested_with_nulls:

Expected output:

nested(message.info)|nested(comment.data)
|hh
b|aa
c|aa
c|ab
a|ab
zz|[aa, bb]
zz|[aa, bb]
|ee
a|ab
rr|[asdf, sdfg]

Actual output:

nested(message.info)|nested(comment.data)
|hh
b|aa
c|aa
c|ab
a|ab
zz|[aa, bb
]
zz|[aa, bb
]
|ee
a|ab
rr|[asdf, sdfg
]

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

What is the expected behavior?
A clear and concise description of what you expected to happen.

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

@acarbonetto acarbonetto added bug Something isn't working untriaged labels Apr 21, 2023
@acarbonetto
Copy link
Collaborator Author

Note: this might be related to errors in Dashboard processing raw and csv format from the V2 engine (seems to work for the legacy engine).

@Yury-Fridlyand
Copy link
Collaborator

Detected the same issue with csv format without nested:
V1

POST http://localhost:9200/_plugins/_sql?format=csv
{
    "query" : "select * from account where account_number = 70",
    "legacy": 1
}
account_number,firstname,address,balance,gender,city,employer,state,age,email,lastname
70,Deidre,685 School Lane,38172,F,Chestnut,Netplode,GA,33,[email protected],Thompson

V2

POST http://localhost:9200/_plugins/_sql?format=csv
{
    "query" : "select * from account where account_number = 70"
}
account_number,firstname,address,balance,gender,city,employer,state,age,email,lastname
70,Deidre,
685 School Lane,
38172,F,Chestnut,Netplode,GA,
33,[email protected],Thompson

@matthewryanwells
Copy link
Contributor

I've narrowed down that this bug is caused by the fact in legacy the header defines the content-type as text/plain; charset=UTF-8 while in the new engine the content-type is application/json; charset=UTF-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.9.0 v2.9.0
Projects
None yet
4 participants