Skip to content

cnf core: use GetGVR() instead of GetServiceGVR()#209

Merged
klaskosk merged 1 commit intorh-ecosystem-edge:mainfrom
sebrandon1:service_gvr_deprecated
Mar 14, 2025
Merged

cnf core: use GetGVR() instead of GetServiceGVR()#209
klaskosk merged 1 commit intorh-ecosystem-edge:mainfrom
sebrandon1:service_gvr_deprecated

Conversation

@sebrandon1
Copy link
Copy Markdown
Collaborator

Builds on: rh-ecosystem-edge/eco-goinfra#667

Bumps the version of eco-goinfra. GetServiceGVR() has been deprecated in favor of a more generic GetGVR() to match other functions in eco-goinfra.

@sebrandon1 sebrandon1 requested a review from kononovn September 18, 2024 15:33
@sebrandon1 sebrandon1 self-assigned this Sep 18, 2024
@sebrandon1 sebrandon1 force-pushed the service_gvr_deprecated branch 3 times, most recently from 1e1e447 to a01dc55 Compare October 3, 2024 16:54
@sebrandon1 sebrandon1 force-pushed the service_gvr_deprecated branch from a01dc55 to 07deb51 Compare March 14, 2025 14:10
@sebrandon1 sebrandon1 requested a review from klaskosk March 14, 2025 14:27
Copy link
Copy Markdown
Collaborator

@klaskosk klaskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
cc: @gkopels @evgenLevin

@klaskosk klaskosk merged commit c526042 into rh-ecosystem-edge:main Mar 14, 2025
1 check passed
@sebrandon1 sebrandon1 deleted the service_gvr_deprecated branch March 14, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants