Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary name oran-o2ims or just o2ims #104

Closed
tshefi opened this issue Jun 20, 2024 · 2 comments
Closed

Binary name oran-o2ims or just o2ims #104

tshefi opened this issue Jun 20, 2024 · 2 comments

Comments

@tshefi
Copy link
Contributor

tshefi commented Jun 20, 2024

Cloned the repo, ran 'make binary' indeed created the oran-o2ims binary,
however if we issue the --help flag, we're suggesting the command should be just "o2ims"
yet there is no such binary, a bit confusing,
either we rename the created binary to o2ims or update help's output.

$ ./oran-o2ims --help
{"time":"2024-06-20T08:50:29Z","level":"INFO","msg":"Command","args":["./oran-o2ims","--help"]}
O2 IMS

Usage:
o2ims [command]
Available Commands:
completion Generate the autocompletion script for the specified shell
..
Use "o2ims [command] --help" for more information about a command.

jhernand added a commit to jhernand/oran-o2ims that referenced this issue Jun 20, 2024
Currently the name of the binary is `oran-o2ims` but the output of the
`--help` option says `o2ims`. This patch fixes that.

Related: openshift-kni#104
Signed-off-by: Juan Hernandez <[email protected]>
@jhernand
Copy link
Collaborator

Certainly confusing, fixed in #105 changing the help text.

jhernand added a commit that referenced this issue Jun 20, 2024
Currently the name of the binary is `oran-o2ims` but the output of the
`--help` option says `o2ims`. This patch fixes that.

Related: #104

Signed-off-by: Juan Hernandez <[email protected]>
@jhernand
Copy link
Collaborator

Fixed in #105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants