Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to validate mcp has picked up chnages before issuing "unpause" #35

Closed
davidvossel opened this issue Jan 9, 2020 · 2 comments
Closed

Comments

@davidvossel
Copy link
Member

from this discussion #25 (comment)

lets see if there's a way to introspect the mcp to determine whether it has picked up the configs we've posted before unpausing it.

Maybe we won't be able to introspect all changes were picked up, but at least seeing that the changes we can check have been picked up gives us some assurance that the mcp has at least been updated.

This is mostly an optimization. The worst case scenario is we reboot a node twice to apply changes if we unpause too early.

@davidvossel davidvossel mentioned this issue Jan 9, 2020
5 tasks
@slintes
Copy link
Member

slintes commented Feb 25, 2020

we don't create the MCP in the operator code anymore, so this is obsolete

/close

@openshift-ci-robot
Copy link
Collaborator

@slintes: Closing this issue.

In response to this:

we don't create the MCP in the operator code anymore, so this is obsolete

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dshchedr pushed a commit to dshchedr/performance-addon-operators that referenced this issue Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants