Skip to content

Conversation

@infernus01
Copy link
Member

@infernus01 infernus01 commented Jun 19, 2025

It extends the existing opc version command to include the OpenShift product version information.
Jira: SRVKP-2124

Changes:

  • Added logic to detect OpenShift environment and fetch OpenShift product version
  • Display OpenShift product version in opc version output.

Sample Output:

$ ./opc version
OpenShift Pipelines Client: devel
Tekton CLI: 0.41.0
Pipelines as Code CLI: 0.35.0
Tekton Results CLI: 0.15.0
Manual Approval Gate CLI: 0.6.0
OpenShift Pipelines: test

@infernus01
Copy link
Member Author

cc @divyansh42 @pratap0007

@divyansh42
Copy link
Contributor

/ok-to-test

@divyansh42
Copy link
Contributor

@infernus01 can we write unit tests for the opc version command?

@infernus01
Copy link
Member Author

@divyansh42 I don't see test files anywhere, should I add a new test file for version.go ?

@divyansh42
Copy link
Contributor

@divyansh42 I don't see test files anywhere, should I add a new test file for version.go ?

Yes, I think we should add a new file for the test

@infernus01
Copy link
Member Author

/cc @divyansh42

@aThorp96 aThorp96 requested a review from savitaashture July 3, 2025 13:41
@divyansh42
Copy link
Contributor

@infernus01 thanks for adding the unit tests.
Can you please also add the command for running the unit tests in the Makefile and then integrate that with the GitHub action, so that it runs as a part of CI checks on every PR.

@infernus01
Copy link
Member Author

@divyansh42 added the command to run tests in the makefile and integrated that into actions yaml as well.

@divyansh42
Copy link
Contributor

@savitaashture can you please approve the run so that we can test the changes in the github actions?

@infernus01
Copy link
Member Author

/cc @aThorp96

@infernus01
Copy link
Member Author

cc @pratap0007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants