fix: address CodeRabbit review findings

- mlflow_backend.py: set mlflow.runName tag explicitly when resuming a
  run with run_id, since some MLflow versions ignore run_name in
  start_run() during resume
- export.py: wrap MLFLOW_WORKSPACE restoration in finally block so it
  executes even if set_experiment/start_run raises
- export.py: validate tracking_uri with assert_tracking_uri_has_no_userinfo()
  before composing the Slack-visible MLflow URL

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Harshith-umesh

projects/caliper/engine/file_export/mlflow_backend.py

@@ -423,6 +423,8 @@ def _run(uri: str | None) -> tuple[str, dict[str, Any] | None]:
         client = mlflow.tracking.MlflowClient()
         with mlflow.start_run(**start_kw):
             rid = mlflow.active_run().info.run_id
+            if run_id and run_name:
+                mlflow.set_tag("mlflow.runName", run_name)
             _apply_run_metadata(effective_meta)
             _apply_log_model(artifact_root, effective_meta, verbose=verbose)
 
@@ -560,6 +562,8 @@ def _run(uri: str | None) -> tuple[str, dict[str, Any] | None]:
 
         with mlflow.start_run(**start_kw) as parent:
             parent_rid = parent.info.run_id
+            if run_id and parent_run_name:
+                mlflow.set_tag("mlflow.runName", parent_run_name)
             _apply_run_metadata(effective_meta)
 
             _upload_mlflow_files_parallel(

projects/caliper/orchestration/export.py

@@ -308,24 +308,25 @@ def precreate_mlflow_run() -> dict[str, str]:
     tracking_uri = secrets_data.get("tracking_uri", "")
 
     prev_workspace = os.environ.get("MLFLOW_WORKSPACE")
-    with mlflow_connection_env(secrets_data):
-        if tracking_uri:
-            mlflow.set_tracking_uri(tracking_uri)
-        if workspace:
-            os.environ["MLFLOW_WORKSPACE"] = workspace
-        if experiment:
-            mlflow.set_experiment(experiment)
-
-        run_name = os.environ.get("FJOB_NAME")
-        with mlflow.start_run(run_name=run_name):
-            active = mlflow.active_run()
-            run_id = active.info.run_id
-            experiment_id = str(active.info.experiment_id)
-
-    if prev_workspace is not None:
-        os.environ["MLFLOW_WORKSPACE"] = prev_workspace
-    else:
-        os.environ.pop("MLFLOW_WORKSPACE", None)
+    try:
+        with mlflow_connection_env(secrets_data):
+            if tracking_uri:
+                mlflow.set_tracking_uri(tracking_uri)
+            if workspace:
+                os.environ["MLFLOW_WORKSPACE"] = workspace
+            if experiment:
+                mlflow.set_experiment(experiment)
+
+            run_name = os.environ.get("FJOB_NAME")
+            with mlflow.start_run(run_name=run_name):
+                active = mlflow.active_run()
+                run_id = active.info.run_id
+                experiment_id = str(active.info.experiment_id)
+    finally:
+        if prev_workspace is not None:
+            os.environ["MLFLOW_WORKSPACE"] = prev_workspace
+        else:
+            os.environ.pop("MLFLOW_WORKSPACE", None)
 
     logger.info("Pre-created MLflow run %s (experiment=%s)", run_id, experiment_id)
 
@@ -364,7 +365,9 @@ def _read_mlflow_ids_from_marker() -> tuple[str, str]:
 def build_mlflow_run_url() -> str:
     """Construct the MLflow run URL at runtime from vault secrets and the marker file."""
     try:
-        from projects.caliper.engine.file_export.mlflow_secrets import load_mlflow_secrets_yaml
+        from projects.caliper.engine.file_export.mlflow_secrets import (
+            load_mlflow_secrets_yaml,
+        )
         from projects.core.library import config
 
         run_id, experiment_id = _read_mlflow_ids_from_marker()
@@ -391,6 +394,7 @@ def build_mlflow_run_url() -> str:
         tracking_uri = secrets_data.get("tracking_uri", "").rstrip("/")
         if not tracking_uri.startswith(("http://", "https://")):
             return ""
+        assert_tracking_uri_has_no_userinfo(tracking_uri)
 
         workspace = config.project.get_config(
             "caliper.export.backend.mlflow.config.workspace", None, print=False, warn=False