Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Ansible-Lint skipped rules #10

Open
kpouget opened this issue Aug 22, 2023 · 1 comment
Open

Review Ansible-Lint skipped rules #10

kpouget opened this issue Aug 22, 2023 · 1 comment

Comments

@kpouget
Copy link
Contributor

kpouget commented Aug 22, 2023

In this PR we updated the Ansible linter, but also introduce multiple "skipped" rules (to keep the CI green).

These skipped rules should be reviewed, and decided one by one if the rule should be enforced or skipped.

Rules that are skipped:

  - 'command-instead-of-module'
  - 'command-instead-of-shell'
  - 'deprecated-local-action'
  - 'key-order[task]'
  - 'jinja[spacing]'
  - 'no-free-form'
  - 'chema[meta]'
  - 'name[missing]'
  - 'var-naming[no-reserved]'
  - 'var-naming[no-role-prefix]'
  - 'var-naming[pattern]'
  - 'yaml[colons]'
  - 'yaml[commas]'
  - 'yaml[comments]'
  - 'yaml[empty-lines]'
  - 'yaml[indentation]'
  - 'yaml[key-duplicates]'
  - 'yaml[line-length]'
  - 'yaml[new-line-at-end-of-file]'
  - 'yaml[octal-values]'
  - 'yaml[trailing-spaces]'
  - 'yaml[truthy]'
  - 'name[template]'
  - 'name[casing]'
  - 'risky-file-permissions'
  - 'risky-shell-pipe'
  - 'ignore-errors'
  - 'no-changed-when'
  - 'fqcn'
  - 'args[module]'

rules that should be enforced, at first glance:


-    command-instead-of-shell
-    jinja[spacing]
-    yaml[new-line-at-end-of-file]
-    risky-shell-pip
-    name[missing]
@kpouget kpouget mentioned this issue Aug 22, 2023
Merged
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
ba37505 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'name[missing]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
ff9b57e 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'name[missing]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
63f1633 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'name[missing]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
aa30cd1 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'name[missing]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
c7cfe86 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'name[missing]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
5c1bf59 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'name[missing]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
216207a 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'name[missing]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
6c0ceb3 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'name[missing]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
d0668f9 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
b84e5a4 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
@ccamacho ccamacho mentioned this issue Aug 25, 2023
Merged
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
b1716e7 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
fa8a5b9 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
ef7fca2 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
@ccamacho
Copy link
Collaborator

I think also running some bashate checks anywhere where bash/command is used will be useful

ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
8e29fa5 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
d881bce 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
0f622e5 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
bc6a81d 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 25, 2023
@ccamacho
testing: lints partial fixes
06a3af8 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 27, 2023
@ccamacho
testing: lints partial fixes
ae483bd 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 28, 2023
@ccamacho
testing: lints partial fixes
d43c7e2 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment
like `tox -e linters` instead of consuming the GH action.

Partially-solves: openshift-psap#10
kpouget added a commit that referenced this issue Aug 28, 2023
@kpouget
testing: lints partial fixes (#16)
56a37fe 
This commit resolves the following lint rules:

- 'key-order[task]'
- 'jinja[spacing]'
- 'name[missing]'
- 'yaml[new-line-at-end-of-file]'
- 'yaml[trailing-spaces]'
- 'risky-shell-pipe'
- 'args[module]'

Also removes the branch constraint to run
the Ansible lint checks from any fork. This
is useful because in each contributor's fork
when pushing specific named branches the checks
will be executed, a future improvement could be
to run all the lints checks from a single environment like `tox -e
linters` instead of consuming the GH action.

Partially-solves: #10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 29, 2023
@ccamacho
testing: lints partial fixes
8c9be3a 
This commit resolves the following lint rules:

- 'var-naming[no-reserved]'
- 'var-naming[no-role-prefix]'
- 'var-naming[pattern]'
- 'yaml[colons]'
- 'yaml[commas]'
- 'yaml[comments]'
- 'yaml[empty-lines]'
- 'yaml[indentation]'
- 'yaml[key-duplicates]'
- 'yaml[line-length]'
- 'yaml[octal-values]'
- 'name[template]'
- 'name[casing]'

Partially-solves: openshift-psap#10
@ccamacho ccamacho mentioned this issue Aug 29, 2023
Merged
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 29, 2023
@ccamacho
testing: lints partial fixes
572b20e 
This commit resolves the following lint rules:

- 'var-naming[no-reserved]'
- 'var-naming[no-role-prefix]'
- 'var-naming[pattern]'
- 'yaml[colons]'
- 'yaml[commas]'
- 'yaml[comments]'
- 'yaml[empty-lines]'
- 'yaml[indentation]'
- 'yaml[key-duplicates]'
- 'yaml[line-length]'
- 'yaml[octal-values]'
- 'name[template]'
- 'name[casing]'

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 29, 2023
@ccamacho
testing: lints partial fixes
8a6d9f2 
This commit resolves the following lint rules:

- 'var-naming[no-reserved]'
- 'var-naming[no-role-prefix]'
- 'var-naming[pattern]'
- 'yaml[colons]'
- 'yaml[commas]'
- 'yaml[comments]'
- 'yaml[empty-lines]'
- 'yaml[indentation]'
- 'yaml[key-duplicates]'
- 'yaml[line-length]'
- 'yaml[octal-values]'
- 'name[template]'
- 'name[casing]'

Partially-solves: openshift-psap#10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 29, 2023
@ccamacho
testing: lints partial fixes
cb840d2 
This commit resolves the following lint rules:

- 'var-naming[no-reserved]'
- 'var-naming[no-role-prefix]'
- 'var-naming[pattern]'
- 'yaml[colons]'
- 'yaml[commas]'
- 'yaml[comments]'
- 'yaml[empty-lines]'
- 'yaml[indentation]'
- 'yaml[key-duplicates]'
- 'yaml[line-length]'
- 'yaml[octal-values]'
- 'name[template]'
- 'name[casing]'

Partially-solves: openshift-psap#10
kpouget added a commit that referenced this issue Aug 29, 2023
@kpouget
testing: lints partial fixes (#22)
666961b 
This commit resolves the following lint rules:

- 'var-naming[no-reserved]'
- 'var-naming[no-role-prefix]'
- 'var-naming[pattern]'
- 'yaml[colons]'
- 'yaml[commas]'
- 'yaml[comments]'
- 'yaml[empty-lines]'
- 'yaml[indentation]'
- 'yaml[key-duplicates]'
- 'yaml[line-length]'
- 'yaml[octal-values]'
- 'name[template]'
- 'name[casing]'

Partially-solves: #10
ccamacho added a commit to ccamacho/topsail that referenced this issue Aug 29, 2023
@ccamacho
testing: lints partial fixes
26ddb92 
This commit resolves the following lint rules:

- 'var-naming[no-reserved]'
- 'var-naming[no-role-prefix]'
- 'var-naming[pattern]'
- 'yaml[colons]'
- 'yaml[commas]'
- 'yaml[comments]'
- 'yaml[empty-lines]'
- 'yaml[indentation]'
- 'yaml[key-duplicates]'
- 'yaml[line-length]'
- 'yaml[octal-values]'
- 'name[template]'
- 'name[casing]'

Partially-solves: openshift-psap#10
@ccamacho ccamacho mentioned this issue Aug 29, 2023
Merged
kpouget added a commit that referenced this issue Aug 29, 2023
@kpouget
testing: lint and docs improvements (#24)
82f3f12 
This commit resolves the following lint rules:

- 'yaml'
- 'yaml[truthy]'
- 'risky-file-permissions'
- 'no-changed-when'

It moves 'yaml' to 'yaml[indentation]' and 'yaml[line-length]' to avoid
skipping rules that are needed.

Adds an exclusion folder for the .github folder due to
ansible/ansible-lint#3645

Updates the toolbox repo 'generate_ansible_default_settings' option to
enforce the linting of the parameters and constants.

Partially solves: #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kpouget @ccamacho