From b3489aaf7ec00cf1fef2c3a222449fb95dc1f7e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jiri=20Dan=C4=9Bk?= Date: Tue, 10 Dec 2024 09:38:46 +0100 Subject: [PATCH] Allow requests for ephemeral-storage in validation/config.go --- pkg/validation/config.go | 2 +- pkg/validation/config_test.go | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/pkg/validation/config.go b/pkg/validation/config.go index 9653f3b084..b368f3bcb4 100644 --- a/pkg/validation/config.go +++ b/pkg/validation/config.go @@ -567,7 +567,7 @@ func validateResourceList(fieldRoot string, list api.ResourceList) []error { var numInvalid int for key := range list { switch key { - case "cpu", "memory", api.ShmResource, api.NvidiaGPUResource: + case "cpu", "memory", "ephemeral-storage", api.ShmResource, api.NvidiaGPUResource: quantity, err := resource.ParseQuantity(list[key]) if err != nil { validationErrors = append(validationErrors, fmt.Errorf("%s.%s: invalid quantity: %w", fieldRoot, key, err)) diff --git a/pkg/validation/config_test.go b/pkg/validation/config_test.go index 2b79d36ad3..94b1c36cb6 100644 --- a/pkg/validation/config_test.go +++ b/pkg/validation/config_test.go @@ -249,6 +249,20 @@ func TestValidateResources(t *testing.T) { }, expectedErr: true, }, + { + name: "valid ephemeral-storage value passes", + input: api.ResourceConfiguration{ + "*": api.ResourceRequirements{ + Requests: api.ResourceList{ + "ephemeral-storage": "60Gi", + }, + Limits: api.ResourceList{ + "ephemeral-storage": "100Gi", + }, + }, + }, + expectedErr: false, + }, { name: "valid shm value passes", input: api.ResourceConfiguration{