[release-4.18] OCPBUGS-62637: Machine-config controller should actively manage cordon while draining

[djoshy]

Manual cherry-pick of #5300

The 4.18 drain controller does not use an MCP informer, so I had to do some minor adjustments for that.

[djoshy]

/jira cherry-pick OCPBUGS-62003

[openshift-ci-robot]

@djoshy: Jira Issue OCPBUGS-62003 has been cloned as Jira Issue OCPBUGS-62637. Will retitle bug to link to clone.
/retitle OCPBUGS-62637: drain: re-cordon nodes if needed

In response to this:

/jira cherry-pick OCPBUGS-62003

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-62637, which is invalid:

• expected dependent Jira Issue OCPBUGS-62003 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry-pick of #5300

The 4.19 drain controller does not use an MCP informer, so I had to do some minor adjustments for that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/label backport-risk-assessed
/lgtm

Clean backport!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ptalgulk01]

/verified later by @ptalgulk01

[openshift-ci-robot]

@ptalgulk01: Only users can be targets for the /verified later command.

In response to this:

/verified later by @ptalgulk01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ptalgulk01]

/verified later @ptalgulk01

[openshift-ci-robot]

@ptalgulk01: This PR has been marked to be verified later by @ptalgulk01.

In response to this:

/verified later @ptalgulk01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pablintino]

/retest-required

[djoshy]

/jira refresh

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-62637, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.z) matches configured target version for branch (4.18.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-62003 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-62003 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
• bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/override ci/prow/e2e-aws-ovn

This PR has passed this job on this commit before, it is currently failing due to infra issues.

[openshift-ci]

@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

This PR has passed on this job on this commit before, it is currently failing due to infra issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change	eb17591	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn	eb17591	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[djoshy]

/test unit

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e009cca and 2 for PR HEAD eb17591 in total

[openshift-ci-robot]

@djoshy: Jira Issue OCPBUGS-62637: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#5322

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-62637 has been moved to the MODIFIED state.

In response to this:

Manual cherry-pick of #5300

The 4.18 drain controller does not use an MCP informer, so I had to do some minor adjustments for that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.