Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Support section from OKD docs #58576

Closed
mburke5678 opened this issue Apr 12, 2023 · 10 comments
Closed

Remove Support section from OKD docs #58576

mburke5678 opened this issue Apr 12, 2023 · 10 comments

Comments

@mburke5678
Copy link
Contributor

Please remove the "Support" section of the OKD Product Docs.

okd-project/working-group#2

@mburke5678
Copy link
Contributor Author

PR in progress: #58577

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 18, 2023
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2023
@gabriel-rh
Copy link
Contributor

Based on the topic map, should the "Getting support" page be output at all for OKD?

Name: Support
Dir: support
Distros: openshift-enterprise,openshift-online,openshift-origin
Topics:
- Name: Support overview
  File: index
- Name: Managing your cluster resources
  File: managing-cluster-resources
- Name: Getting support
  File: getting-support
  Distros: openshift-enterprise

I would have thought that the Distros: setting on the File: would override that on the Dir: and as a result, asciibinder should not output this page for OKD but it does...

@gabriel-rh
Copy link
Contributor

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 30, 2023
@gabriel-rh
Copy link
Contributor

If you use build_for_portal.py on the OKD distro, it shows that the "getting-started" file is not included in the distro:

$ python3 build_for_portal.py --distro openshift-origin --product "OKD" --version 4.13 --no-upstream-fetch
...
Processing support
ERROR (support/index.adoc): "xref:../support/getting-support.adoc#getting-support[Get support]" appears to try to reference a file not included in the "openshift-origin" distro
Processing web_console

And in the drupal-build master.adoc file that it generates, it does not include getting-support.adoc

= Support
:product-author: Red Hat OpenShift Documentation Team
:product-title: OKD
:product-version: 4.13
:openshift-origin:
:imagesdir: images
:idseparator: -

include::index.adoc[leveloffset=+1]

include::managing-cluster-resources.adoc[leveloffset=+1]
...

So it looks like there is a conflict between how asciibinder implements inheritance in the topic map, and how build_for_portal does it.

Personally, I believe build_for_portal is correct here...

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2023
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 29, 2023
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Jan 29, 2024
Copy link

openshift-ci bot commented Jan 29, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants