[WIP] [DNM] Reverts 49e141a0a41793f94750a8bc998af05b7033dd91 #2438
Conversation
Using cryptorand ends up making a syscall to udev/random and takes too much CPU since this is called on every enqueue event. We don't need cryptographic random numbers as we are not generating tokens or certificates. In the future, we should look at implementing a heap and storing queues by size on the heap. That would make it faster than the current method, but for now this is the least risky option. Signed-off-by: Tim Rozet <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test qe-perfscale-aws-ovn-small-node-density-cni |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Using cryptorand ends up making a syscall to udev/random and takes too much CPU since this is called on every enqueue event. We don't need cryptographic random numbers as we are not generating tokens or certificates.
In the future, we should look at implementing a heap and storing queues by size on the heap. That would make it faster than the current method, but for now this is the least risky option.
📑 Description
Fixes #
Additional Information for reviewers
✅ Checks
How to verify it