Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Testing downstream: Make dbus controller more efficient #2440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Feb 6, 2025

The previous code was iterating a for loop every 50ms to try to detect if there was a state change to an internal cache provided by coreos dbus package. This consumes too much CPU. Instead, directly use dbus to receive systemd unit events. This drastically reduces CPU and still detects when Kubelet is restarted.

Signed-off-by: Tim Rozet [email protected]
(cherry picked from commit 84dee1f59bcff40ec296d01d61c17f0b5a7d1cb3)

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

The previous code was iterating a for loop every 50ms to try to detect
if there was a state change to an internal cache provided by coreos dbus
package. This consumes too much CPU. Instead, directly use dbus to receive
systemd unit events. This drastically reduces CPU and still detects when
Kubelet is restarted.

Signed-off-by: Tim Rozet <[email protected]>
(cherry picked from commit 84dee1f59bcff40ec296d01d61c17f0b5a7d1cb3)
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2025
@openshift-ci openshift-ci bot requested review from jcaamano and tssurya February 6, 2025 02:53
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@jtaleric
Copy link

jtaleric commented Feb 6, 2025

/test qe-perfscale-payload-control-plane-6nodes

Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-techpreview bd26029 link false /test e2e-azure-ovn-techpreview
ci/prow/security bd26029 link false /test security
ci/prow/e2e-aws-ovn-local-gateway bd26029 link true /test e2e-aws-ovn-local-gateway
ci/prow/e2e-metal-ipi-ovn-ipv4-bgp-techpreview bd26029 link false /test e2e-metal-ipi-ovn-ipv4-bgp-techpreview
ci/prow/e2e-metal-ipi-ovn-ipv6-techpreview bd26029 link false /test e2e-metal-ipi-ovn-ipv6-techpreview
ci/prow/e2e-vsphere-ovn-techpreview bd26029 link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-openstack-ovn bd26029 link false /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn bd26029 link false /test e2e-azure-ovn
ci/prow/okd-scos-e2e-aws-ovn bd26029 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack bd26029 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-azure-ovn-upgrade bd26029 link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants