-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Testing downstream: Make dbus controller more efficient #2440
base: master
Are you sure you want to change the base?
Conversation
The previous code was iterating a for loop every 50ms to try to detect if there was a state change to an internal cache provided by coreos dbus package. This consumes too much CPU. Instead, directly use dbus to receive systemd unit events. This drastically reduces CPU and still detects when Kubelet is restarted. Signed-off-by: Tim Rozet <[email protected]> (cherry picked from commit 84dee1f59bcff40ec296d01d61c17f0b5a7d1cb3)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test qe-perfscale-payload-control-plane-6nodes |
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The previous code was iterating a for loop every 50ms to try to detect if there was a state change to an internal cache provided by coreos dbus package. This consumes too much CPU. Instead, directly use dbus to receive systemd unit events. This drastically reduces CPU and still detects when Kubelet is restarted.
Signed-off-by: Tim Rozet [email protected]
(cherry picked from commit 84dee1f59bcff40ec296d01d61c17f0b5a7d1cb3)
📑 Description
Fixes #
Additional Information for reviewers
✅ Checks
How to verify it