Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [DNM] Testing only Perf improvement: egress ip/qos reroute rules #2460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Feb 14, 2025

These things were constantly being executed on every node update. Bring them inline with what we do for other node syncs, keep a cache of what needs to be sync'ed. The impact of this was especially bad for UDN.

📑 Description

Fixes #

Additional Information for reviewers

✅ Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

These things were constantly being executed on every node update. Bring
them inline with what we do for other node syncs, keep a cache of what
needs to be sync'ed. The impact of this was especially bad for UDN.

Signed-off-by: Tim Rozet <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2025
Copy link
Contributor

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@mohit-sheth
Copy link
Member

/test qe-perfscale-aws-ovn-small-udn-density-l3

Copy link
Contributor

openshift-ci bot commented Feb 15, 2025

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade da830b9 link true /test e2e-aws-ovn-upgrade
ci/prow/security da830b9 link false /test security
ci/prow/e2e-vsphere-ovn da830b9 link false /test e2e-vsphere-ovn
ci/prow/e2e-azure-ovn da830b9 link false /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-windows da830b9 link true /test e2e-aws-ovn-windows
ci/prow/e2e-metal-ipi-ovn-ipv4-bgp-techpreview da830b9 link false /test e2e-metal-ipi-ovn-ipv4-bgp-techpreview
ci/prow/e2e-gcp-ovn da830b9 link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6-techpreview da830b9 link false /test e2e-metal-ipi-ovn-ipv6-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants