Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift-sdn does not allow to configure a custom mac #15

Closed
alonSadan opened this issue Jul 25, 2019 · 4 comments
Closed

openshift-sdn does not allow to configure a custom mac #15

alonSadan opened this issue Jul 25, 2019 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@alonSadan
Copy link

openshift-sdn does not allow to configure a custom mac.

I am copying here @booxter thorough explanation for the similar issue on ovn-kubernetes:

OK, let me expand because it sounds like perhaps Alon asked the project to come up with its own solution for hardware addresses, while in reality there is prior art in CNI plugins for the same.

The Network Plumbing working group of Kubernetes came up with a standard for network attachment definitions: https://docs.google.com/document/d/1Ny03h6IDVy_e_vmElOqR7UdTPAG_RNydhVE1Kx54kFQ/edit

This document explains how additional networks can be attached to pods and is implemented by Multus CNI plugin. This document defines, among other things, the mac attribute that can be passed via CNI_ARGS into the plugin. If it's passed, then the plugin is supposed to enforce it for the prepared binding. This feature is already implemented in multiple CNI plugins (e.g. ovs-cni, sriov-cni), it can also be implemented not natively via tuning plugin chaining. Other projects like KubeVirt / kubemacpool rely on this attribute for some features to work.

It would be very helpful if OVN-Kubernetes plugin adds support for this attribute like other plugins did, so that we can use it in KubeVirt / kubemacpool environments.

Thank you for consideration.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2020
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 14, 2020
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants