-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift-sdn does not allow to configure a custom mac #15
Comments
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-sdn does not allow to configure a custom mac.
I am copying here @booxter thorough explanation for the similar issue on ovn-kubernetes:
OK, let me expand because it sounds like perhaps Alon asked the project to come up with its own solution for hardware addresses, while in reality there is prior art in CNI plugins for the same.
The Network Plumbing working group of Kubernetes came up with a standard for network attachment definitions: https://docs.google.com/document/d/1Ny03h6IDVy_e_vmElOqR7UdTPAG_RNydhVE1Kx54kFQ/edit
This document explains how additional networks can be attached to pods and is implemented by Multus CNI plugin. This document defines, among other things, the mac attribute that can be passed via CNI_ARGS into the plugin. If it's passed, then the plugin is supposed to enforce it for the prepared binding. This feature is already implemented in multiple CNI plugins (e.g. ovs-cni, sriov-cni), it can also be implemented not natively via tuning plugin chaining. Other projects like KubeVirt / kubemacpool rely on this attribute for some features to work.
It would be very helpful if OVN-Kubernetes plugin adds support for this attribute like other plugins did, so that we can use it in KubeVirt / kubemacpool environments.
Thank you for consideration.
The text was updated successfully, but these errors were encountered: