fix up startup / informer usage

[danwinship]

(We probably won't actually fix this, but I did the analysis and want to dump it somewhere.)

We keep running into problems with the fact that openshift-sdn-node doesn't wait for its informers to be ready at startup.

Here's what sdn-node startup currently looks like:

pkg/cmd/openshift-sdn/node/cmd.go: run()

  sdn.init()
    sdn.buildInformers()
    sdn.initSDN()
      sdnnode.New()
        NewNetworkPolicyPlugin()
          newNodeVNIDMap()
        NewOVSController()
        common.NewEgressDNS()
        newHostSubnetWatcher()
        newPodManager()
        newEgressIPWatcher()
          common.NewEgressIPTracker()
    sdn.initProxy()
      sdnproxy.New()
        common.NewEgressDNS()

  sdn.start()
    sdn.runSDN()
      sdn.osdnNode.Start()
        node.getLocalSubnet()
        newNodeIPTables()
        nodeIPTables.Setup()
        node.SetupSDN()
        hostSubnets.Start()
          watchHostSubnets()
        node.policy.Start()
          vnids.Start()
            populateVNIDs()
              common.ListAllNetNamespaces()
            watchNetNamespaces()
          initNamespaces()
            common.ListAllNamespaces()
            common.ListAllNetworkPolicies()
          watchNamespaces()
          watchPods()
          watchNetworkPolicies()
        node.SetupEgressNetworkPolicy()
          common.ListAllEgressNetworkPolicies()
          plugin.policy.GetVNID()
          plugin.watchEgressNetworkPolicies()
        node.egressIP.Start()
          eip.tracker.Start()
            watchHostSubnets()
            watchNetNamespaces()
            watchNodes()
            go WaitForCacheSync()
        node.watchServices()
        node.podManager.InitRunningPods()
          m.policy.GetVNID()
        node.podManager.Start()
        node.reattachPods()
          node.podManager.handleCNIRequest()
            podManager.setup()
              m.kClient.CoreV1().Pods().Get()
              m.policy.GetVNID()
        node.FinishSetupSDN()
    sdn.runProxy()
      newProxyServer()
      wrapProxy()
        sdn.SetBaseProxies()
          NewHybridProxier()
        sdn.osdnProxy.Start()
          common.GetParsedClusterNetwork()
          common.ListAllEgressNetworkPolicies()
	  proxy.watchEgressNetworkPolicies()
	  proxy.watchNetNamespaces()
      startProxyServer()
        informers.NewSharedInformerFactoryWithOptions()
        informerFactory.Start()

    sdn.informers.start()

ideally we would call sdn.informers.start() between sdn.init() and sdn.start() (and then get rid of all of the ListAll* methods and just use the informer listers). But this would require reorganizing stuff so that all of the "watch" methods get called at init time. Right now the split between init and start is mostly there to allow for unit tests that don't use clients/informers, but that could be fixed by just using fake clients/informers in the unit tests.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.