Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA Scheduled on Master Nodes #164

Open
scottd018 opened this issue May 22, 2024 · 2 comments
Open

VPA Scheduled on Master Nodes #164

scottd018 opened this issue May 22, 2024 · 2 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@scottd018
Copy link

Is there a reason that the VPA operator is scheduled on the master nodes as part of the operator installation process? See https://github.com/openshift/vertical-pod-autoscaler-operator/blob/master/install/deploy/03_deployment.yaml#L56

From the upstream (https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/deploy) it looks like this is not a hard requirement for the project.

The reason I ask, is it creates a problem with our managed cloud services (e.g. ROSA), specifically with Hosted Control Plane which do not expose any master nodes within the cluster, which creates a poor experience for those users.

Happy to PR if we can remove this requirement, otherwise was curious to discuss.

FWIW, we were able to work around this by editing the Subscription resource following a failed deployment, but that is not ideal from a UX perspective IMO:

spec:
  channel: stable
  config:
    nodeSelector:
      node-role.kubernetes.io/worker: ""
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

2 participants