Skip to content

Commit 95a8381

Browse files
committed
Move "HiddenOnMobile" up the hierarchy
1 parent 9120343 commit 95a8381

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

src/app/content/highlights/components/EditCard.tsx

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -76,16 +76,20 @@ function LoginOrEdit({
7676
>
7777
{
7878
authenticated ? (
79-
(props.shouldFocusCard || props.data?.annotation) ? (
80-
<form
81-
ref={mergeRefs(fref, element)}
82-
data-analytics-region='edit-note'
83-
data-highlight-card
84-
>
85-
<ActiveEditCard props={props} element={element} />
86-
</form>
87-
) :
88-
<i>Press Enter or double-click highlight to edit highlight</i>
79+
<HiddenOnMobile>
80+
{
81+
(props.shouldFocusCard || props.data?.annotation) ? (
82+
<form
83+
ref={mergeRefs(fref, element)}
84+
data-analytics-region='edit-note'
85+
data-highlight-card
86+
>
87+
<ActiveEditCard props={props} element={element} />
88+
</form>
89+
) :
90+
<i>Press Enter or double-click highlight to edit highlight</i>
91+
}
92+
</HiddenOnMobile>
8993
) : <LoginConfirmation onBlur={props.onBlur} />
9094
}
9195
</div>
@@ -205,7 +209,7 @@ function ActiveEditCard({
205209
useTrapTabNavigation(ref, editingAnnotation);
206210

207211
return (
208-
<HiddenOnMobile ref={ref}>
212+
<div ref={ref}>
209213
<ColorPicker
210214
color={props.data?.color}
211215
onChange={onColorChange}
@@ -248,7 +252,7 @@ function ActiveEditCard({
248252
always={() => setConfirmingDelete(false)}
249253
/>
250254
)}
251-
</HiddenOnMobile>
255+
</div>
252256
);
253257
}
254258

0 commit comments

Comments
 (0)