Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split Javascripts.share.image_dimensions to allow translations #5195

Open
maro-21 opened this issue Sep 11, 2024 · 2 comments
Open

split Javascripts.share.image_dimensions to allow translations #5195

maro-21 opened this issue Sep 11, 2024 · 2 comments

Comments

@maro-21
Copy link

maro-21 commented Sep 11, 2024

This string https://translatewiki.net/wiki/Osm:Javascripts.share.image_dimensions/en takes the %{layer} parameter from exisiting translation of names of Layers, which are in the nominative case. Other languages need the accusative case (or other) here. So

should have their translation equivalents as part of this sentence.

@mmd-osm
Copy link
Contributor

mmd-osm commented Oct 13, 2024

Looking through existing translations, it might be even better to have three separate strings for each of the three relevant layers. Instead of "Image will show the %{layer} layer at %{width} x %{height} ", that would be:

  • Image will show the Standard layer at %{width} x %{height}
  • Image will show the Cycle map layer at %{width} x %{height}
  • Image will show the Transport Map layer at %{width} x %{height}

@maro-21 : what do you think about this proposal?

@maro-21
Copy link
Author

maro-21 commented Oct 13, 2024

Yes, it sounds like a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants