Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes controller calls set_locale after lookup_user which can cause unexpected language for 404 users notes #5251

Open
Firefishy opened this issue Oct 7, 2024 · 4 comments
Labels
bug Something is broken or not working as expected i18n Internationalisation - related to translation into different languages

Comments

@Firefishy
Copy link
Member

URL

https://www.openstreetmap.org/user/Omaraltab/notes

How to reproduce the issue?

Refreshing the URL occasionally returns the 404 page in an unexpected language.

before_action :lookup_user, :only => [:index]

Screenshot(s) or anything else?

Page unexpectedly in German:
Screenshot 2024-10-07 at 11 40 39

@tomhughes
Copy link
Member

We probably need to review all the lookup_user calls and make sure they come after set_locale and probably web_timeout as well though that's unlikely to matter much.

@Firefishy Firefishy added bug Something is broken or not working as expected i18n Internationalisation - related to translation into different languages labels Oct 7, 2024
@mmd-osm

This comment was marked as off-topic.

@tomhughes
Copy link
Member

It's not really related at all though other than in the most tangential way.

@mmd-osm

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected i18n Internationalisation - related to translation into different languages
Projects
None yet
Development

No branches or pull requests

3 participants