Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to move away from dartsass-ruby #5313

Open
tomhughes opened this issue Nov 12, 2024 · 2 comments
Open

We need to move away from dartsass-ruby #5313

tomhughes opened this issue Nov 12, 2024 · 2 comments

Comments

@tomhughes
Copy link
Member

We are currently using dartsass-ruby as a dependency of dartsass-sprockets but v1.x of the uri gem has an ABI change which breaks it:

bin/rails aborted!
ArgumentError: wrong number of arguments (given 1, expected 0) (ArgumentError)
/home/tom/.bundle/ruby/3.3.0/gems/uri-1.0.1/lib/uri/rfc3986_parser.rb:73:in `initialize'
/home/tom/.bundle/ruby/3.3.0/gems/dartsass-ruby-3.0.2/lib/sassc/url.rb:5:in `new'
/home/tom/.bundle/ruby/3.3.0/gems/dartsass-ruby-3.0.2/lib/sassc/url.rb:5:in `<module:URL>'
/home/tom/.bundle/ruby/3.3.0/gems/dartsass-ruby-3.0.2/lib/sassc/url.rb:4:in `<module:SassC>'
/home/tom/.bundle/ruby/3.3.0/gems/dartsass-ruby-3.0.2/lib/sassc/url.rb:3:in `<main>'
/home/tom/.bundle/ruby/3.3.0/gems/dartsass-ruby-3.0.2/lib/sassc.rb:54:in `require_relative'
/home/tom/.bundle/ruby/3.3.0/gems/dartsass-ruby-3.0.2/lib/sassc.rb:54:in `<main>'

As dartsass-ruby has been abandoned it seems either dartsass-sprockets will need updating or we will need to replace it.

@tomhughes
Copy link
Member Author

Ah it has already been changed in dartsass-sprockets but we have a version lock on sass-embedded which is stopping it from updating.

@tomhughes
Copy link
Member Author

The version lock is from 41f13ac and it seems our bootstrap is still too old to avoid the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant