Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CTS] - Key Event Notifications - Add FIlter rules to opentelekomcloud_cts_event_notification_v3 #2790

Open
uli-schneider opened this issue Jan 17, 2025 · 5 comments
Open

[CTS] - Key Event Notifications - Add FIlter rules to opentelekomcloud_cts_event_notification_v3 #2790

uli-schneider opened this issue Jan 17, 2025 · 5 comments
Assignees
@artem-lifshits
Labels
enhancement otc-issue Blocked by OTC issues

Comments

@uli-schneider
Copy link

Description of the enhancement

CTS event notification supports filter rules.

Image

Complete API Page:
https://docs.otc.t-systems.com/cloud-trace-service/api-ref/v3_apis_recommended/key_event_notification_management/creating_a_key_event_notification.html#

Table 5: Filter:
https://docs.otc.t-systems.com/cloud-trace-service/api-ref/v3_apis_recommended/key_event_notification_management/creating_a_key_event_notification.html#cts-api-0312-en-us-topic-0000001213559235-request-filter

Please add to opentelekomcloud_cts_event_notification_v3.

Thanks!
@artem-lifshits artem-lifshits self-assigned this Jan 31, 2025
@artem-lifshits artem-lifshits mentioned this issue Feb 3, 2025
Merged
5 tasks
otc-zuul bot pushed a commit that referenced this issue Feb 3, 2025
@artem-lifshits
[Feat.] CTS: even notification filter (#2809)
2aa7494 
[Feat.] CTS: even notification filter

Summary of the Pull Request
New filter parameter for opentelekomcloud_cts_event_notification_v3
PR Checklist

 Refers to: #2790
 Tests added/passed.
 Documentation updated.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
=== RUN   TestAccCTSEventNotificationV3_basic
--- PASS: TestAccCTSEventNotificationV3_basic (56.92s)
PASS

Process finished with the exit code 0

Reviewed-by: Aloento
Reviewed-by: Anton Sidelnikov
Reviewed-by: Muneeb H. Jan <[email protected]>
@artem-lifshits
Copy link
Member

Implemented in latest release.

@uli-schneider
Copy link
Author

It is not perfect working.

The "api" parameter "is_support_filter" is missing.

Image

While "overview" in console looks fine:

Image

In the "modify" rule, the settings/filter rule are not visible.

Image

Click-Ops Created rule:

Image

(1) "is_support_filter"
(2) Created rule is visible

Please add this parameter in next sprint.

@artem-lifshits
Copy link
Member

@uli-schneider OTC issue, not sure if it's API or console problem, I've opened a ticket for that
https://jira.tsi-dev.otc-service.com/browse/OTCPAAS-2600

@artem-lifshits
Copy link
Member

FYI tf provider already utilizes is_support_filter field so user doesn't have to specify it:

Image

@uli-schneider
Copy link
Author

Thanks for explanation.

@artem-lifshits artem-lifshits added the otc-issue Blocked by OTC issues label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artem-lifshits artem-lifshits

Labels
enhancement otc-issue Blocked by OTC issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artem-lifshits @uli-schneider