Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md doesn't reflect state of repo #118

Open
PatrikSteuer opened this issue Jan 25, 2021 · 6 comments
Open

Readme.md doesn't reflect state of repo #118

PatrikSteuer opened this issue Jan 25, 2021 · 6 comments

Comments

@PatrikSteuer
Copy link

Problem

The readme states that a trace propagation via the w3c headers is possible. However the mentioned property opentracing.jaeger.enable-w3c-propagation does not work with the latest (3.2.2) version due to a #107 which reverted several commits before releasing.

This is a state which causes confusion.

Solutions

  1. Adopt readme and remove the w3c trace propagation
  2. Add commits reverted by Bump Spring Boot to 2.3.4.Release for Jaeger 1.1 #107 and release a new version

Due to the need for the w3c trace propagation I would favour the second approach.

@geoand
Copy link
Collaborator

geoand commented Jan 25, 2021

You are right!

Can you please remind me towards the end of the week to do a new release as to implement solution 2?

Thanks

@PatrikSteuer
Copy link
Author

Hi @geoand,
this is your friendly reminder to release a new version, including the w3c trace propagation.
Best
Patrik

@poznachowski
Copy link

Hey! Is there any ETA on upgrading jager-client to 1.3.2 ?

@geoand
Copy link
Collaborator

geoand commented Feb 1, 2021

Hi,

I just opened #119 to bump the client.

Once that is in, I'll do a new release

@poznachowski
Copy link

Thanks! How long does it take for the new release to be available on Maven central ?

@geoand
Copy link
Collaborator

geoand commented Feb 2, 2021

You are welcome.

It usually takes around 24 hours to sync to Maven Central

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants