-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tags #288
Comments
I confirm keeping tags in sync with your released versions would be helpful for Debian and probably others as well. |
Greetings, I concur getting the tags in sync with the pypi releases would be helpful. The release is currently tracked on pypi, but it lacks test data present in the git tree. This prevents independent runs of the test suite without some more manual work involved to identify the right version associated to the release in the git tree. Thanks for considering, |
Seems like a popular request! Is there an easy way to script tagging the
HEAD with the current version in the deploy script?
…On Sat, Feb 24, 2024, 8:10 AM Étienne Mollier ***@***.***> wrote:
Greetings,
I concur getting the tags in sync with the pypi releases would be helpful.
The release is currently tracked on pypi, but it lacks test data present in
the git tree. This prevents independent runs of the test suite without some
more manual work involved to identify the right version associated to the
release in the git tree.
Thanks for considering,
Étienne.
—
Reply to this email directly, view it on GitHub
<#288 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAL2OMHLBBQHFG7LC2JSZTYVHRFXAVCNFSM6AAAAAA3RJT5QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGM3DANRXHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hi Alex, Thanks for your interest in the issue, if I were to automate the tagging along delivery, my change would look something like that: diff --git a/deploy.sh b/deploy.sh
index c1896d9..5f15b69 100755
--- a/deploy.sh
+++ b/deploy.sh
@@ -4,4 +4,6 @@ python3 -m pip install --upgrade build && \
python3 -m pip install --upgrade twine && \
rm -rf dist && \
python3 -m build && \
-python3 -m twine upload dist/*
+python3 -m twine upload dist/* && \
+git tag "$(python3 pyensembl/version.py)" && \
+git push --tags
diff --git a/pyensembl/version.py b/pyensembl/version.py
index 04510af..852f460 100644
--- a/pyensembl/version.py
+++ b/pyensembl/version.py
@@ -1 +1,4 @@
__version__ = "2.3.9"
+
+if __name__ == "__main__":
+ print(__version__) This is not tested though (I wouldn't run a push to pypi without your supervision:), and maybe you would prefer another ordering of the commands e.g. if one step fails but not another, but you get the idea. In hope this helps, |
Is the new version doing the desired thing with tags? (sorry I'm so ignorant about git tags, I never use them) |
Looks like it's working? |
Hi Alex, Yes, I confirm that it works great. Thank you for having streamlined git tagging, this is very useful to easily refer to important milestones in your source tree. I think the present issue is resolved now. Have a nice day, :) |
I am working with pyensembl in Debian and would prefer to pull source code from Github instead of PyPi. The releases are up to date in PyPi but not in Github. Can you please update the tags for the current version 2.2.8 and future versions?
The text was updated successfully, but these errors were encountered: