Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tags #288

Open
linqigang888 opened this issue Aug 15, 2023 · 7 comments
Open

Update tags #288

linqigang888 opened this issue Aug 15, 2023 · 7 comments

Comments

@linqigang888
Copy link

I am working with pyensembl in Debian and would prefer to pull source code from Github instead of PyPi. The releases are up to date in PyPi but not in Github. Can you please update the tags for the current version 2.2.8 and future versions?

@tillea
Copy link

tillea commented Aug 16, 2023

I confirm keeping tags in sync with your released versions would be helpful for Debian and probably others as well.

@emollier
Copy link

Greetings,

I concur getting the tags in sync with the pypi releases would be helpful. The release is currently tracked on pypi, but it lacks test data present in the git tree. This prevents independent runs of the test suite without some more manual work involved to identify the right version associated to the release in the git tree.

Thanks for considering,
Étienne.

@iskandr
Copy link
Contributor

iskandr commented Feb 24, 2024 via email

@emollier
Copy link

Hi Alex,

Thanks for your interest in the issue, if I were to automate the tagging along delivery, my change would look something like that:

diff --git a/deploy.sh b/deploy.sh
index c1896d9..5f15b69 100755
--- a/deploy.sh
+++ b/deploy.sh
@@ -4,4 +4,6 @@ python3 -m pip install --upgrade build && \
 python3 -m pip install --upgrade twine && \
 rm -rf dist && \
 python3 -m build && \
-python3 -m twine upload dist/*
+python3 -m twine upload dist/* && \
+git tag "$(python3 pyensembl/version.py)" && \
+git push --tags
diff --git a/pyensembl/version.py b/pyensembl/version.py
index 04510af..852f460 100644
--- a/pyensembl/version.py
+++ b/pyensembl/version.py
@@ -1 +1,4 @@
 __version__ = "2.3.9"
+
+if __name__ == "__main__":
+    print(__version__)

This is not tested though (I wouldn't run a push to pypi without your supervision:), and maybe you would prefer another ordering of the commands e.g. if one step fails but not another, but you get the idea.

In hope this helps,
Étienne.

@iskandr
Copy link
Contributor

iskandr commented Feb 27, 2024

Is the new version doing the desired thing with tags?

(sorry I'm so ignorant about git tags, I never use them)

@iskandr
Copy link
Contributor

iskandr commented Feb 28, 2024

Looks like it's working?

https://github.com/openvax/pyensembl/tags

@emollier
Copy link

Hi Alex,

Yes, I confirm that it works great. Thank you for having streamlined git tagging, this is very useful to easily refer to important milestones in your source tree. I think the present issue is resolved now.

Have a nice day, :)
Étienne.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants