Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent database #22

Closed
jrhender opened this issue Feb 2, 2024 · 1 comment
Closed

Persistent database #22

jrhender opened this issue Feb 2, 2024 · 1 comment

Comments

@jrhender
Copy link
Contributor

jrhender commented Feb 2, 2024

Currently, the app uses an in-memory DB for now for app execution and tests. The rationale for this for executions that, as the app is only being used in a demo context, it is not necessary to persist data between executions. The rationale for this for tests (rather than mocking the db) is that it speeds test writing time, elimates mocking boilerplate and possibly buggy DB mocks.

However, a persistent database is important for non-PoC applications.

A PR to implement this here; however it would need to be ported to this repo. energywebfoundation/ssi#158
@jrhender
Copy link
Contributor Author

jrhender commented Oct 3, 2024

Closing as SQLite was implemented in #38

@jrhender jrhender closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrhender