Use libindy with rusql fix for ios build

[Patrik-Stas]

Includes new version of libindy with this changes which fixes a bug present on iOS where thread panics on wallet opening.

In order to successfully build for iOS however, we have to use the vendored feature for openssl dependency. This, in turn, breaks compilation for the musl C environment on Alpine. Hence, X86_64_ALPINE_LINUX_MUSL_OPENSSL_NO_VENDOR environment variable was set as a way to not use the vendored flag on Alpine. This is a temporary fix, as the plan is to remove the dependency on openssl completely.

Signed-off-by: Patrik Stas patrik.stas@absa.africa
Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

[Patrik-Stas]

We would have to release indy-sdk to get into android, as for Android we rely on prebuilt libindy binaries

[codecov-commenter]

Codecov Report

Merging #306 (f6fb54e) into master (2714cef) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #306   +/-   ##
=======================================
  Coverage   49.66%   49.66%           
=======================================
  Files         154      154           
  Lines       19607    19606    -1     
  Branches     6190     6199    +9     
=======================================
  Hits         9738     9738           
- Misses       5072     5076    +4     
+ Partials     4797     4792    -5     

Flag	Coverage Δ
integration	22.10% <ø> (+<0.01%)	⬆️
unittests	45.48% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
agency_client/src/error.rs	16.80% <0.00%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2714cef...f6fb54e. Read the comment docs.

[mirgee]

What is the purpose of changing this from v1.16.0 to the tag v1.16.0 commit?

[Patrik-Stas]

Experiment ^_^

[mirgee]

Moreover, why do you link the binary against a different version of the indy crate?

...
indy = "1.16.0"
indy-sys = "1.16.0"
...

[Patrik-Stas]

Moreover, why do you link the binary against a different version of the indy crate?

...
indy = "1.16.0"
indy-sys = "1.16.0"
...

Good catch 👍 thanks

[mirgee]

Successfully verified that the error on wallet opening is not present on iOS device with this build anymore.

[Patrik-Stas]

I was looking at this and got concerned about the feature description

The vendored copy will not be configured to automatically find the system’s root certificates, but the openssl-probe crate can be used to do that instead.

So I went through actual usage of openssl crate and it turn out it might be an overkill. What's being used is:

use openssl::sha::sha256
use openssl::bn::BigNum;

I somewhat presumed openssl is there because reqwest needs it, but reqwest comes has its own tls dependency https://github.com/seanmonstar/reqwest/blob/master/Cargo.toml

So our openssl usage is not actually ever dealing with certificates, so the quote on top of this comment doesn't matter. I think ultimate solution will be to get rid of openssl dependency.
Perhaps:

• https://github.com/RustCrypto/hashes for Sha256
• https://github.com/rust-num/num-bigint for big integer

But lets do that separately

[Patrik-Stas]

@mirgee I am the original submitter of this PR, so I can't click approve as you mostly did the heavy lifting.

So please feel free to approve on my behalf, just note the comments I've left.

[mirgee]

Approved on behalf of @Patrik-Stas