Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog improvements #387

Open
berezh opened this issue Dec 3, 2020 · 0 comments
Open

Dialog improvements #387

berezh opened this issue Dec 3, 2020 · 0 comments

Comments

@berezh
Copy link
Contributor

berezh commented Dec 3, 2020

Currently, it opens/closes with state flag within a component.
Disadvantages:

  • need to create additional flag in redux store to handle case the form successfully submitted, subscribe it and if it true - close the dialog. This hack makes app complicated and increases possibility to get a but.
  • dialog can be opened/closed only from specific component by subscribing state flag

To resolve above need to move opeding/closing to redux action.
Example here - a0a1bae#diff-731b906bcd8593e0a5402f1657db9a50bc9066ce8bbd3b37c7760071098e6fb8R12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@berezh