You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
The current AbortSubscription method in SubscriptionHandler does one too many things - it aborts the subscription and reset the state of the handler if the refcount is one value (1) and releases the handler back to the pool if it's another (0).
This overloading is confusing, error-prone and causes un-necessary stack winding - calling AbortSubscription to abort a subscription results in aborting the subscription (1), then calling Release which calls AbortSubscription again, this time to handle (2).
This should be re-factored to separate out aborting a subscription, and releasing the handler object back to the pool.
This issue corresponds to WEAV-2367.
The text was updated successfully, but these errors were encountered:
The current AbortSubscription method in SubscriptionHandler does one too many things - it aborts the subscription and reset the state of the handler if the refcount is one value (1) and releases the handler back to the pool if it's another (0).
This overloading is confusing, error-prone and causes un-necessary stack winding - calling AbortSubscription to abort a subscription results in aborting the subscription (1), then calling Release which calls AbortSubscription again, this time to handle (2).
This should be re-factored to separate out aborting a subscription, and releasing the handler object back to the pool.
This issue corresponds to WEAV-2367.
The text was updated successfully, but these errors were encountered: