Move log entries that we are submitting set grades to right before we…

… actually try to submit them
openwebwork · Nov 26, 2024 · 2c87c17 · 2c87c17
1 parent 3067000
commit 2c87c17
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lib/WeBWorK/Authen/LTIAdvanced/SubmitGrade.pm b/lib/WeBWorK/Authen/LTIAdvanced/SubmitGrade.pm
@@ -154,9 +154,6 @@ async sub submit_set_grade ($self, $userID, $setID, $submittedSet = undef) {
 	my $user = $db->getUser($userID);
 	return 0 unless $user;
 
-	$self->warning("Submitting grade for user $userID and set $setID.")
-		if $ce->{debug_lti_grade_passback} || $self->{post_processing_mode};
-
 	my $userSet = $submittedSet // $db->getMergedSet($userID, $setID);
 	unless ($userSet->lis_source_did) {
 		$self->warning('lis_source_did is not available for this set.')
@@ -167,6 +164,8 @@ async sub submit_set_grade ($self, $userID, $setID, $submittedSet = undef) {
 	my $score = getSetPassbackScore($db, $ce, $userID, $userSet, !$self->{post_processing_mode});
 	return -1 unless $score;
 
+	$self->warning("Submitting grade for user $userID and set $setID.")
+		if $ce->{debug_lti_grade_passback} || $self->{post_processing_mode};
 	return await $self->submit_grade($userSet->lis_source_did, $score->{score});
 }
 

diff --git a/lib/WeBWorK/Authen/LTIAdvantage/SubmitGrade.pm b/lib/WeBWorK/Authen/LTIAdvantage/SubmitGrade.pm
@@ -235,7 +235,6 @@ async sub submit_set_grade ($self, $userID, $setID, $submittedSet = undef) {
 	my $user = $db->getUser($userID);
 	return 0 unless $user;
 
-	$self->warning("Submitting grade for user $userID and set $setID.");
 	unless ($user->lis_source_did) {
 		$self->warning('LMS user id is not available for this user.');
 		return 0;
@@ -250,6 +249,7 @@ async sub submit_set_grade ($self, $userID, $setID, $submittedSet = undef) {
 	my $score = getSetPassbackScore($db, $ce, $userID, $userSet, !$self->{post_processing_mode});
 	return -1 unless $score;
 
+	$self->warning("Submitting grade for user $userID and set $setID.");
 	return await $self->submit_grade($user->lis_source_did, $userSet->lis_source_did, $score->{totalRight},
 		$score->{total});
 }