[chores] Requested changes

- Minor changes in device.js
- Revert changes in old migrations

Author: purhan

openwisp_controller/config/migrations/0013_last_ip_management_ip_and_status_applied.py

@@ -64,10 +64,7 @@ class Migration(migrations.Migration):
             name='management_ip',
             field=models.GenericIPAddressField(
                 blank=True,
-                help_text='IP address used by OpenWISP to reach the device when '
-                'performing any type of push operation or active check. The value '
-                'of this field is generally sent by the device and hence does not '
-                'need to be changed, but can be changed or cleared manually if needed.',
+                help_text='ip address of the management interface, if available',
                 null=True,
             ),
         ),

openwisp_controller/config/migrations/0027_add_indexes_on_ip_fields.py

@@ -27,11 +27,7 @@ class Migration(migrations.Migration):
             field=models.GenericIPAddressField(
                 blank=True,
                 db_index=True,
-                help_text='This is the IP address used by OpenWISP to reach the '
-                'device when performing any type of push operation or active '
-                'check. The value of this field is generally sent by the device '
-                'and hence does not need to be changed, but can be changed or '
-                'cleared manually if needed.',
+                help_text='ip address of the management interface, if available',
                 null=True,
             ),
         ),

openwisp_controller/config/static/config/css/admin.css

@@ -310,6 +310,10 @@ button.show-sc{
 #main .form-row.field-location .item-label {
   bottom: -7px
 }
+#edit_management_ip {
+  margin-left: 7px;
+  opacity: 0.8;
+}
 
 @media (max-width: 767px) {
   ul.tabs li {

openwisp_controller/config/static/config/js/device.js

@@ -6,17 +6,17 @@ django.jQuery(function ($) {
 
   // replaces the management ip field with text with the option to edit it
   var ip_input = $(".field-management_ip > div > input");
-  var initial_ip = ip_input.prop("value");
+  var initial_ip = ip_input.val();
   ip_input.after(function () {
     ip_input.hide();
     return (
       '<span class="readonly" id="management_ip_text">' +
-      (initial_ip === "" ? "-n/a-" : initial_ip) +
+      (initial_ip === "" ? "-" : initial_ip) +
       "</span>"
     );
   });
   $("#management_ip_text").after(
-    '<a id="edit_management_ip">  <img src="/static/admin/img/icon-changelink.svg" alt="Edit"></a>'
+    '<a id="edit_management_ip"><img src="/static/admin/img/icon-changelink.svg" alt="Edit"></a>'
   );
   $("#edit_management_ip").click(function () {
     var ip_text = $("#management_ip_text");