Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] JavaScript error on Access credentials add/edit page #334

Closed
pandafy opened this issue Dec 4, 2020 · 1 comment · Fixed by #336
Closed

[bug] JavaScript error on Access credentials add/edit page #334

pandafy opened this issue Dec 4, 2020 · 1 comment · Fixed by #336
Assignees
@NoumbissiValere
Labels
bug Important Higher priority or release blocker

Comments

@pandafy
Copy link
Member

pandafy commented Dec 4, 2020

Steps to replicate:

1, Run development server
2. Visit http://localhost/admin/connection/credentials/add/

image

Thanks to @nemesisdesign for reporting this in #333 (review)

@NoumbissiValere do you have any thoughts regarding the cause of the bug?
@pandafy pandafy added the bug label Dec 4, 2020
@nemesifier
Copy link
Member

Thanks for testing on master @pandafy. Looks like it's been introduced in the system defined variables PR.

@nemesifier nemesifier mentioned this issue Dec 4, 2020
Open
@nemesifier nemesifier added the Important Higher priority or release blocker label Dec 4, 2020
@NoumbissiValere NoumbissiValere self-assigned this Dec 6, 2020
NoumbissiValere added a commit that referenced this issue Dec 6, 2020
@NoumbissiValere
[fix] Fixed system context js error #334
64d29f4 
Fixes #334
@NoumbissiValere NoumbissiValere mentioned this issue Dec 6, 2020
Merged
nemesifier pushed a commit that referenced this issue Dec 7, 2020
@NoumbissiValere
[fix] Fixed system context JS error #334
94c20a1 
Fixes #334
@pandafy pandafy mentioned this issue Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoumbissiValere NoumbissiValere

Labels
bug Important Higher priority or release blocker
Projects
OpenWISP Priorities for next releases
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Fixed system context js error #334 openwisp/openwisp-controller
3 participants
@nemesifier @NoumbissiValere @pandafy