Skip to content

Commit fc1932a

Browse files
committed
Malformed URL raises on init
1 parent b656f38 commit fc1932a

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ as of 0.8.2
1212

1313
- Ability to test delete access via check_credentials or standalone
1414

15+
### Changed
16+
17+
- Malformed URL raises on init
18+
1519
### Fixed
1620

1721
- testing write access requires delete permission (#11)

src/kiwixstorage/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,9 @@ def __init__(self, url, **kwargs):
191191
def _parse_url(self, url, **kwargs):
192192
try:
193193
self.url = urllib.parse.urlparse(url)
194+
for part in ("scheme", "netloc"):
195+
if not getattr(self.url, part):
196+
raise ValueError(f"Incorrect URL: missing {part}")
194197
env = {
195198
k.lower(): v for k, v in urllib.parse.parse_qs(self.url.query).items()
196199
}

0 commit comments

Comments
 (0)