Improve failure messages for reporting

[jcchavezs]

Error log messages for reporting are meaningless https://github.com/openzipkin/zipkin-go/blob/master/reporter/http/http.go#L139 end up in

2018/11/07 13:28:24 failed the request with status code 503

in logs which might not be useful. I was thinking on

2018/11/07 13:28:24 failed the request to zipkin collector with status code 503

Any suggestion @adriancole @basvanbeek ?

[codefromthecrypt]

if logging probably saying the endpoint is enough to clarify.

…

On Wed, 7 Nov 2018, 22:39 José Carlos Chávez, ***@***.***> wrote: Error log messages for reporting are meaningless https://github.com/openzipkin/zipkin-go/blob/master/reporter/http/http.go#L139 end up in 2018/11/07 13:28:24 failed the request with status code 503 in logs which might not be useful. I was thinking on 2018/11/07 13:28:24 failed the request to zipkin collector with status code 503 Any suggestion @adriancole <https://github.com/adriancole> @basvanbeek <https://github.com/basvanbeek> ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#91>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD614vk8FqpfXZoIohNoYIN9kajEb1Cks5usvCPgaJpZM4YSja2> .

[jcchavezs]

@adriancole I actually see the value of printing both, sometimes you don't know what 172.x.x.12/v2/api/spans is whereas sometimes problem is that people uses /api/v2/spans so including both might do the trick:

2018/11/07 13:28:24 failed the request to zipkin collector (172.x.x.12/v2/api/spans) with status code 503

[basvanbeek]

I think logging inside zipkin-go still needs a major overhaul. We shouldn't make assumptions on how stuff is being logged from within a library... that's an application concern.

Let's fix that and see what we need to do to improve reporting quality.

See #37

[jcchavezs]

Since we are injecting a logger there is not much application can control (more than an mdc). My only point here is that those isolated messages are not understandable per se, people usually copy the text and look into the application code because they are kinda críptic. I do agree we need to improve the logging but I also think improving the message is a quick win. Den man. 3. des. 2018, 17:01 skrev Bas van Beek <[email protected]:

…

I think logging inside zipkin-go still needs a major overhaul. We shouldn't make assumptions on how stuff is being logged from within a library... that's an application concern. Let's fix that and see what we need to do to improve reporting quality. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#91 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7sAnY0_PzBT1dj4t02PoR7ZheB4iDoks5u1UrpgaJpZM4YSja2> .