From 06424ef35cd2225495ce0f89faaf90a6e9749309 Mon Sep 17 00:00:00 2001 From: Mikalai Radchuk <509198+m1kola@users.noreply.github.com> Date: Tue, 17 Sep 2024 22:29:20 +0200 Subject: [PATCH] Fix `http.DefaultClient` (#1278) We do not want to modify `http.DefaultClient` because it can cause undesired effects in other places. Signed-off-by: Mikalai Radchuk --- internal/catalogmetadata/cache/cache_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/catalogmetadata/cache/cache_test.go b/internal/catalogmetadata/cache/cache_test.go index 05ea28ec5..51b554721 100644 --- a/internal/catalogmetadata/cache/cache_test.go +++ b/internal/catalogmetadata/cache/cache_test.go @@ -212,8 +212,9 @@ func TestFilesystemCache(t *testing.T) { cacheDir := t.TempDir() tt.tripper.content = make(fstest.MapFS) maps.Copy(tt.tripper.content, tt.contents) - httpClient := http.DefaultClient - httpClient.Transport = tt.tripper + httpClient := &http.Client{ + Transport: tt.tripper, + } c := cache.NewFilesystemCache(cacheDir, func() (*http.Client, error) { return httpClient, nil })