Skip to content

Commit c06baaf

Browse files
committed
review comments
Signed-off-by: rashmi_kh <[email protected]>
1 parent ff9cd88 commit c06baaf

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

internal/authentication/tokengetter.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func (e *ServiceAccountNotFoundError) Unwrap() error {
3333

3434
// Error implements the error interface for ServiceAccountNotFoundError.
3535
func (e *ServiceAccountNotFoundError) Error() string {
36-
return fmt.Sprintf("service account \"%s\" not found in namespace \"%s\": unable to authenticate with the Kubernetes cluster.", e.ServiceAccountName, e.ServiceAccountNamespace)
36+
return fmt.Sprintf("service account %q not found in namespace %q: unable to authenticate with the Kubernetes cluster.", e.ServiceAccountName, e.ServiceAccountNamespace)
3737
}
3838

3939
type TokenGetterOption func(*TokenGetter)

internal/controllers/suite_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func (m *MockInstalledBundleGetter) SetBundle(bundle *controllers.InstalledBundl
8383

8484
func (m *MockInstalledBundleGetter) GetInstalledBundle(ctx context.Context, ext *ocv1.ClusterExtension) (*controllers.InstalledBundle, error) {
8585
if m.err != nil {
86-
return nil, m.err
86+
return m.bundle, m.err
8787
}
8888
return m.bundle, nil
8989
}

0 commit comments

Comments
 (0)