review comments

Signed-off-by: rashmi_kh <[email protected]>
operator-framework · Feb 5, 2025 · c06baaf · c06baaf
1 parent ff9cd88
commit c06baaf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/authentication/tokengetter.go b/internal/authentication/tokengetter.go
@@ -33,7 +33,7 @@ func (e *ServiceAccountNotFoundError) Unwrap() error {
 
 // Error implements the error interface for ServiceAccountNotFoundError.
 func (e *ServiceAccountNotFoundError) Error() string {
-	return fmt.Sprintf("service account \"%s\" not found in namespace \"%s\": unable to authenticate with the Kubernetes cluster.", e.ServiceAccountName, e.ServiceAccountNamespace)
+	return fmt.Sprintf("service account %q not found in namespace %q: unable to authenticate with the Kubernetes cluster.", e.ServiceAccountName, e.ServiceAccountNamespace)
 }
 
 type TokenGetterOption func(*TokenGetter)

diff --git a/internal/controllers/suite_test.go b/internal/controllers/suite_test.go
@@ -83,7 +83,7 @@ func (m *MockInstalledBundleGetter) SetBundle(bundle *controllers.InstalledBundl
 
 func (m *MockInstalledBundleGetter) GetInstalledBundle(ctx context.Context, ext *ocv1.ClusterExtension) (*controllers.InstalledBundle, error) {
 	if m.err != nil {
-		return nil, m.err
+		return m.bundle, m.err
 	}
 	return m.bundle, nil
 }