From c06baaf1b031fad870f1a1a31a0dead8b340ea7c Mon Sep 17 00:00:00 2001 From: rashmi_kh Date: Wed, 5 Feb 2025 17:19:32 +0530 Subject: [PATCH] review comments Signed-off-by: rashmi_kh --- internal/authentication/tokengetter.go | 2 +- internal/controllers/suite_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/authentication/tokengetter.go b/internal/authentication/tokengetter.go index 7870dc8e8..9e563dc39 100644 --- a/internal/authentication/tokengetter.go +++ b/internal/authentication/tokengetter.go @@ -33,7 +33,7 @@ func (e *ServiceAccountNotFoundError) Unwrap() error { // Error implements the error interface for ServiceAccountNotFoundError. func (e *ServiceAccountNotFoundError) Error() string { - return fmt.Sprintf("service account \"%s\" not found in namespace \"%s\": unable to authenticate with the Kubernetes cluster.", e.ServiceAccountName, e.ServiceAccountNamespace) + return fmt.Sprintf("service account %q not found in namespace %q: unable to authenticate with the Kubernetes cluster.", e.ServiceAccountName, e.ServiceAccountNamespace) } type TokenGetterOption func(*TokenGetter) diff --git a/internal/controllers/suite_test.go b/internal/controllers/suite_test.go index 354208abd..398dd5204 100644 --- a/internal/controllers/suite_test.go +++ b/internal/controllers/suite_test.go @@ -83,7 +83,7 @@ func (m *MockInstalledBundleGetter) SetBundle(bundle *controllers.InstalledBundl func (m *MockInstalledBundleGetter) GetInstalledBundle(ctx context.Context, ext *ocv1.ClusterExtension) (*controllers.InstalledBundle, error) { if m.err != nil { - return nil, m.err + return m.bundle, m.err } return m.bundle, nil }