Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the namespace creation manifest in to a single repository #1138

Open
LalatenduMohanty opened this issue Aug 16, 2024 · 1 comment

Comments

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Aug 16, 2024

We have the namespace manifest in both operator-controller [2] and catalogd [1]. However install script [3] applies both one after another. Ideally the namespace should be in just catalogd. Also the pod-security.kubernetes.io/enforce is different in both the repos which needs to be fixed as well i.e. pod-security.kubernetes.io/enforce: baseline vs pod-security.kubernetes.io/enforce: restricted [1] [2]

[1] https://github.com/operator-framework/catalogd/blob/main/config/base/manager/manager.yaml
[2] https://github.com/operator-framework/operator-controller/blob/main/config/base/manager/manager.yaml
[3] https://github.com/operator-framework/operator-controller/blob/main/scripts/install.tpl.sh

@bentito
Copy link
Contributor

bentito commented Aug 19, 2024

Couldn't someone, for dev testing, etc, still want to run just operator-controller? If the deploy/run targets lack the NS deploy they will fail since catalogd hasn't been installed. Is there a drawback to just keeping and let it do nothing when catalogd has been installed already? Seems like it keeps the two components better decoupled to keep them both installing the NS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants