Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add another similar test that includes a deprecated bundle that: #1176

Open
tmshort opened this issue Aug 27, 2024 · 1 comment
Open
Assignees

Comments

@tmshort
Copy link
Contributor

tmshort commented Aug 27, 2024

          Should we add another similar test that includes a deprecated bundle that:
  • is in the version range specified in the cluster extension
  • has a higher semver than other non-deprecated bundles

That way, we:

  • have a unit test that states our intent to our future selves.
  • are sure that deprecated bundles are sorted lower than non-deprecated bundles even if their semver versions are higher.

If we already have this test, apologies!

Originally posted by @joelanford in #1174 (comment)

@tmshort
Copy link
Contributor Author

tmshort commented Aug 27, 2024

May not be needed due to PreferNonDeprecated and AcceptDeprecated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant