Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] operator-controller rejects helm charts that use helm hooks #995

Open
joelanford opened this issue Jul 1, 2024 · 1 comment
Open
Labels
epic v1.x Issues related to OLMv1 features that come after 1.0

Comments

@joelanford
Copy link
Member

joelanford commented Jul 1, 2024

In order to reduce the scope of an initial implementation of helm support in operator-controller, should we proactively reject helm charts that ultimately include chart hooks in their manifests?

Supporting helm chart hooks generally means that we are using helm's libraries to manage the lifecycle of the objects, which has other implications (e.g. see #923).

It also means that there are additional complexities due to the stages introduced by chart hooks (e.g. it is generally not acceptable to block in a Reconcile implementation).

NOTE: This is not immediately important while we are only supporting registry+v1 bundles because operator-controller generates helm charts on-the-fly from registry+v1 bundle content, and it does not use chart hooks.

@joelanford joelanford added epic v1.x Issues related to OLMv1 features that come after 1.0 labels Jul 1, 2024
@joelanford joelanford added this to OLM v1 Jul 1, 2024
@joelanford joelanford changed the title [epic] operator-controller reject helm charts that use helm hooks [epic] operator-controller rejects helm charts that use helm hooks Jul 1, 2024
@LalatenduMohanty
Copy link
Member

This epic is part of #962 but it is a significant piece which needs to represented separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic v1.x Issues related to OLMv1 features that come after 1.0
Projects
Status: No status
Development

No branches or pull requests

2 participants