Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 gracefully shutdown reconcilers and catalogd FBC server #1688

Closed
wants to merge 1 commit into from
+233 −9

gracefully shutdown reconcilers and catalogd FBC

ad9f130
Select commit
Loading
Failed to load commit list.
Closed

🐛 gracefully shutdown reconcilers and catalogd FBC server #1688

gracefully shutdown reconcilers and catalogd FBC
ad9f130
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 4, 2025 in 0s

68.21% (+0.46%) compared to 9b08aea

View this Pull Request on Codecov

68.21% (+0.46%) compared to 9b08aea

Details

Codecov Report

Attention: Patch coverage is 90.47619% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.21%. Comparing base (9b08aea) to head (ad9f130).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rnal/controllers/core/clustercatalog_controller.go 0.00% 6 Missing ⚠️
catalogd/internal/serverutil/serverutil.go 0.00% 1 Missing ⚠️
...nternal/controllers/clusterextension_controller.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   67.74%   68.21%   +0.46%     
==========================================
  Files          57       58       +1     
  Lines        4620     4697      +77     
==========================================
+ Hits         3130     3204      +74     
- Misses       1265     1268       +3     
  Partials      225      225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov