✨ auth: use synthetic user/group when service account is not defined #1816
+263
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
force-pushed
the
synthetic-permissions
branch
3 times, most recently
from
dfc5ccb to
fbcc4a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1816 +/- ##
==========================================
+ Coverage 68.39% 68.64% +0.24%
==========================================
Files 62 63 +1
Lines 5117 5151 +34
==========================================
+ Hits 3500 3536 +36
+ Misses 1388 1387 -1
+ Partials 229 228 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
force-pushed
the
synthetic-permissions
branch
from
fbcc4a5 to
e0c2a55
Compare
Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
synthetic-permissions
branch
from
e0c2a55 to
11210fc
Compare
Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
synthetic-permissions
branch
from
11210fc to
e44c4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today at a meeting among maintainers of OLMv1, we discussed an idea that @thetechnick proposed awhile back. That is: stop using service accounts and service account tokens. Instead use synthetic names with impersonation.
While we are now 1.0.0 with support for service accounts, we can deprecate that feature and recommend attaching permissions to synthetic users/groups instead.
This PR demonstrates how we might do this. But with the API change, we should write up a detailed design and gain consensus.
This PR uses:
"olmv1:clusterextensions:<clusterExtensionName>:admin"["system:authenticated", "olmv1:clusterextensions:admin"]But I'm not sure this is the best setup. There's more discussion to be had around what sythentic names/groups we could derive from a cluster extension.
Reviewer Checklist