Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 e2e: make pods exit faster with terminationGracePeriodSeconds: 0 #1817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Feb 27, 2025

Description

We can make our e2e's significantly faster by making sure pods stop immediately. Setting terminationGracePeriodSeconds: 0 means that kubelet will send the kill signal immediately.

This is okay in our tests because:

  1. For test bundles, we're setting it in the bundle (this is not something OLM itself is doing)
  2. For the metrics pod, we are fine to kill it immediately because we already have the info we need from the kubectl exec call that has already completed.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Joe Lanford <[email protected]>
@joelanford joelanford requested a review from a team as a code owner February 27, 2025 03:26
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e62cd45
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67bfdb64b6a59400090269dc
😎 Deploy Preview https://deploy-preview-1817--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.26%. Comparing base (1573846) to head (e62cd45).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
- Coverage   68.39%   68.26%   -0.14%     
==========================================
  Files          62       62              
  Lines        5117     5117              
==========================================
- Hits         3500     3493       -7     
- Misses       1388     1393       +5     
- Partials      229      231       +2     
Flag Coverage Δ
e2e 51.62% <ø> (-0.16%) ⬇️
unit 55.83% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford
Copy link
Member Author

On this PR, e2e-kind finished in 8m.

Previous runs on main are typically 13-15m: https://github.com/operator-framework/operator-controller/actions/workflows/e2e.yaml?query=branch%3Amain+event%3Apush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant